From mboxrd@z Thu Jan  1 00:00:00 1970
From: Julien Grall <julien.grall@linaro.org>
Subject: Re: [PATCH V3 10/41] xen/mm: Align virtual address on
 PAGE_SIZE in iounmap
Date: Fri, 10 May 2013 13:40:18 +0100
Message-ID: <518CEAB2.40306@linaro.org>
References: <1368152307-598-1-git-send-email-julien.grall@linaro.org>
	<1368152307-598-11-git-send-email-julien.grall@linaro.org>
	<518CCA9302000078000D501E@nat28.tlf.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <518CCA9302000078000D501E@nat28.tlf.novell.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jan Beulich <JBeulich@suse.com>
Cc: Stefano.Stabellini@eu.citrix.com, keir@xen.org, ian.campbell@citrix.com, patches@linaro.org, xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

On 05/10/2013 09:23 AM, Jan Beulich wrote:

>>>> On 10.05.13 at 04:17, Julien Grall <julien.grall@linaro.org> wrote:
>> ioremap function can unlikely return an unaligned virtual address if
>> the physical address itself is unaligned on a page size.
>>
>> Signed-off-by: Julien Grall <julien.grall@linaro.org>
> 
> If you used "unsigned long" instead of "vaddr_t" (I don't think this
> would build on x86 without doing so, as vaddr-t appear to be ARM
> specific):

Right. I will fix it.

> Acked-by: Jan Beulich <jbeulich@suse.com>
> 
>> --- a/xen/include/xen/vmap.h
>> +++ b/xen/include/xen/vmap.h
>> @@ -15,7 +15,9 @@ void __iomem *ioremap(paddr_t, size_t);
>>  
>>  static inline void iounmap(void __iomem *va)
>>  {
>> -    vunmap((void __force *)va);
>> +    vaddr_t addr = (vaddr_t)(void __force *)va;
>> +
>> +    vunmap((void *)(addr & PAGE_MASK));
>>  }
>>  
>>  void vm_init(void);
> 
> 


-- 
Julien