From mboxrd@z Thu Jan  1 00:00:00 1970
From: Julien Grall <julien.grall@linaro.org>
Subject: Re: [PATCH V3 28/41] xen/arm: Add generic UART to get
 the device in the device tree
Date: Fri, 10 May 2013 13:47:09 +0100
Message-ID: <518CEC4D.8080102@linaro.org>
References: <1368152307-598-1-git-send-email-julien.grall@linaro.org>
	<1368152307-598-29-git-send-email-julien.grall@linaro.org>
	<1368178371.27857.38.camel@zakaz.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1368178371.27857.38.camel@zakaz.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: Stefano Stabellini <Stefano.Stabellini@eu.citrix.com>, "Keir (Xen.org)" <keir@xen.org>, "patches@linaro.org" <patches@linaro.org>, "xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
List-Id: xen-devel@lists.xenproject.org

On 05/10/2013 10:32 AM, Ian Campbell wrote:

> On Fri, 2013-05-10 at 03:18 +0100, Julien Grall wrote:
>> This generic UART will find the right UART via xen command line
>> with dtuart=myserial.
>>
>> "myserial" is the alias of the UART in the device tree. Xen will retrieve
>> the information via the device tree and call the initialization function for
>> this specific UART thanks to the device API.
>>
>> Signed-off-by: Julien Grall <julien.grall@linaro.org>
> 
> 
>> CC: keir@xen.org
>>
>> Changes in v3:
>>     - Rename arm-uart.c (resp. arm_uart_init) to dt-uart.c (resp. dt_uart_init)
>>     - Remove serial_arm_defaults and replace by a string options
>>     - Let the specific UART driver to get its base address in the DT
>>     - Add SERHND_DTUART. The value is stolen to SERHND_COM1. Bump the
>>     value would needs some rework...
> 
> This is because of the need to encode the value in 2 bits? Due to
> SERHND_IDX etc, is the rework more than simply changing the mask and
> bumping the flags up and increasing the size of the com array?

The console code is able to handle one serial at time so, I don't
understand why we need to "waste" another memory space for a new kind of
serial.

> I'm OK with this for 4.3 if Keir is:
> 
> Acked-by: Ian Campbell <ian.campbell@citrix.com>
> 
> 


-- 
Julien