From mboxrd@z Thu Jan  1 00:00:00 1970
From: Julien Grall <julien.grall@linaro.org>
Subject: Re: [PATCH V3 37/41] xen/arm: Add exynos 4210 UART
	support
Date: Fri, 10 May 2013 14:00:06 +0100
Message-ID: <518CEF56.1040307@linaro.org>
References: <1368152307-598-1-git-send-email-julien.grall@linaro.org>
	<1368152307-598-38-git-send-email-julien.grall@linaro.org>
	<1368179344.27857.47.camel@zakaz.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1368179344.27857.47.camel@zakaz.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: Anthony Perard <anthony.perard@citrix.com>, Stefano Stabellini <Stefano.Stabellini@eu.citrix.com>, "patches@linaro.org" <patches@linaro.org>, "xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
List-Id: xen-devel@lists.xenproject.org

On 05/10/2013 10:49 AM, Ian Campbell wrote:

> On Fri, 2013-05-10 at 03:18 +0100, Julien Grall wrote:
>> From: Anthony PERARD <anthony.perard@citrix.com>
>>
>> Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
>> Signed-off-by: Julien Grall <julien.grall@linaro.org>
>> [...]
> 
>> +        if ( status & UINTM_ERROR )
>> +        {
>> +            uint32_t error_bit;
>> +
>> +            error_bit = exynos4210_read(uart, UERSTAT);
>> +
>> +            if ( error_bit & UERSTAT_OVERRUN )
>> +                dprintk(XENLOG_ERR, "uart: overrun error\n");
>> +            if ( error_bit & UERSTAT_PARITY )
>> +                dprintk(XENLOG_ERR, "uart: parity error\n");
>> +            if ( error_bit & UERSTAT_FRAME )
>> +                dprintk(XENLOG_ERR, "uart: frame error\n");
>> +            if ( error_bit & UERSTAT_BREAK )
>> +                dprintk(XENLOG_ERR, "uart: break detected\n");
> 
> I'm curious to know where these dprintk's go ;-), but:

Directly on the UART :/. But I'm not sure if UART errors are fatal or not.

> Acked-by: Ian Campbell <ian.campbell@citrix.com>


-- 
Julien