From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek Marczykowski Subject: Re: [PATCH v2 2/2] libvchan: replace munmap with correct xc_gntshr_munmap Date: Fri, 10 May 2013 15:55:16 +0200 Message-ID: <518CFC44.7060607@invisiblethingslab.com> References: <20130508040327.951AD329@duch.mimuw.edu.pl> <518A57ED.5030708@tycho.nsa.gov> <518A5C56.3000100@invisiblethingslab.com> <1368193596.27857.123.camel@zakaz.uk.xensource.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============5479198002439813238==" Return-path: In-Reply-To: <1368193596.27857.123.camel@zakaz.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: George Dunlap , Daniel De Graaf , "xen-devel@lists.xen.org" List-Id: xen-devel@lists.xenproject.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --===============5479198002439813238== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="----enig2FXXQWVCMJXRNAIWQQQQO" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) ------enig2FXXQWVCMJXRNAIWQQQQO Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 10.05.2013 15:46, Ian Campbell wrote: > On Wed, 2013-05-08 at 15:08 +0100, Marek Marczykowski wrote: >> On 08.05.2013 15:49, Daniel De Graaf wrote: >>> On 05/04/2013 06:10 PM, Marek Marczykowski wrote: >>>> On linux it will end up in munmap anyway, but do not assume any >>>> particular xc_gntshr_munmap implementation details. >>>> >>>> Signed-off-by: Marek Marczykowski >>> >>> On a client, this ends up using xc_gntshr_munmap to unmap pages that >>> were mapped with xc_gnttab_map_* instead of using xc_gnttab_unmam >>> >>> George: unless there is another OS besides Linux that implements the >>> xc_gntshr_* interfaces (I found none from a grep of the source), this= >>> is just code clean-up and so could be postponed to 4.4. >> >> This is actually prerequirement for libvchan for mini-os (already post= ed v1, >> working on v2). But as mini-os libvchan isn't targeted for 4.3, this o= ne also >> can wait. >=20 > Is the first patch "libxc: fix xc_gntshr_munmap semantic" also included= > in this assessment? >=20 > Message-Id: <20130508040327.91296310@duch.mimuw.edu.pl> As long as libxenvchan is the only (at least I'm aware of) user of xc_gntshr_munmap - probably yes. But IMO it's better to fix xc_gntshr_mun= map sooner than later, to minimize changes in code that uses it (if someone w= ill start to use it before 4.4 release). --=20 Best Regards, Marek Marczykowski Invisible Things Lab ------enig2FXXQWVCMJXRNAIWQQQQO Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.13 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBAgAGBQJRjPxEAAoJENuP0xzK19csiwYH/iqFvidkwh+Vm3/Dl2zPYnPK m4BDOgrdX9lRZFLVp4js8vHrsfFHy9ysMhvNxwNgY157xOuncKKXXB152MeVLUuG aV/sTzEYSS0HB9Re9mhHXzkyKp7wiPWTXrXzJSIgLVcj5nnIMXr8yMK6Dz5Pc3db QvPD/G4iiwFxiDOX3XLEoFA/FBTr5MUei0sgsJ3Y825rbAwyRDbsmoAcHP2rNBZX D+yEhSFpl4F+sHNyeYjoO+GAmuresi9IiM+AG6CNpce8veYqZMb2qwAXLlrQreUU GN+Nsa5AT9u8MLxeUZklJI5bU6hIMBXzzNY74COHS2EfBrfD0SldCKwKU9z+WdA= =TvWs -----END PGP SIGNATURE----- ------enig2FXXQWVCMJXRNAIWQQQQO-- --===============5479198002439813238== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============5479198002439813238==--