From mboxrd@z Thu Jan  1 00:00:00 1970
From: Julien Grall <julien.grall@linaro.org>
Subject: Re: [PATCH V3 33/41] xen/arm: Add versatile express
	platform
Date: Fri, 10 May 2013 15:10:03 +0100
Message-ID: <518CFFBB.1000901@linaro.org>
References: <1368152307-598-1-git-send-email-julien.grall@linaro.org>
	<1368152307-598-34-git-send-email-julien.grall@linaro.org>
	<1368179099.27857.45.camel@zakaz.uk.xensource.com>
	<518CFD96.8090209@linaro.org>
	<1368194788.27857.131.camel@zakaz.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1368194788.27857.131.camel@zakaz.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: Stefano Stabellini <Stefano.Stabellini@eu.citrix.com>, "patches@linaro.org" <patches@linaro.org>, "xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
List-Id: xen-devel@lists.xenproject.org

On 05/10/2013 03:06 PM, Ian Campbell wrote:

> On Fri, 2013-05-10 at 15:00 +0100, Julien Grall wrote:
>> On 05/10/2013 10:44 AM, Ian Campbell wrote:
>>
>>>> @@ -91,6 +93,47 @@ out:
>>>>  }
>>>>  
>>>>  /*
>>>> + * TODO: Get base address from the device tree
>>>> + * See arm,vexpress-reset node
>>>> + */
>>>> +static void vexpress_reset(void)
>>>> +{
>>>> +    void __iomem *base;
>>>> +    void __iomem *sp810;
>>>> +
>>>> +    /* Use the SP810 system controller to force a reset */
>>>> +    base = ioremap_attr(SP810_ADDRESS & PAGE_MASK, PAGE_SIZE,
>>>> +                        PAGE_HYPERVISOR_NOCACHE);
>>>> +    if ( !base )
>>>> +    {
>>>> +        dprintk(XENLOG_ERR, "Unable to map SP810\n");
>>>> +        return;
>>>> +    }
>>>> +
>>>> +    sp810 = base + (SP810_ADDRESS & ~PAGE_MASK);
>>>
>>> Didn't I see you making vunmap, which iounmap is based on, take care of
>>> the page offsets itself in an earlier patch? Or is that not the reason
>>> you are going through the base + offset dance?
>>
>>
>> I wasn't not sure if you will accept ioremap(..., 8); I will fix the patch.
> 
> I'm confused, what does (..., 8) mean?

Because we only need to the first 8 bytes.

> What I was asking about was why the code couldn't be:
> 	sp810 = ioremap_..(SP810_ADDRESS, PAGE_SIZE,..)
> 	iowritel(sp810,...)
> 	iounmap(sp810)


Indeed. I will use this solution.

-- 
Julien