From mboxrd@z Thu Jan  1 00:00:00 1970
From: Julien Grall <julien.grall@linaro.org>
Subject: Re: [PATCH V3 31/41] xen/arm: Allow Xen to run on
 multiple platform without recompilation
Date: Fri, 10 May 2013 15:47:36 +0100
Message-ID: <518D0888.9070508@linaro.org>
References: <1368152307-598-1-git-send-email-julien.grall@linaro.org>
	<1368152307-598-32-git-send-email-julien.grall@linaro.org>
	<1368178903.27857.43.camel@zakaz.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1368178903.27857.43.camel@zakaz.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: Stefano Stabellini <Stefano.Stabellini@eu.citrix.com>, "patches@linaro.org" <patches@linaro.org>, "xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
List-Id: xen-devel@lists.xenproject.org

On 05/10/2013 10:41 AM, Ian Campbell wrote:

> On Fri, 2013-05-10 at 03:18 +0100, Julien Grall wrote:
>> Xen can include various platform support (ie: exynos5, versatile express...)
>> and choose during boot time a set of callbacks for the current board.
>> These callbacks will be called in places where each board can have specific
>> code. For the moment the callbacks are:
>>     - platform_init: additional initialization for the platform
>>     - platform_init_time: some platform (ie: Exynos 5) needs to initialize
>>     the timer with an uncommon way
>>     - platform_specific_mapping: add mapping to dom0 which are not specified
>>     in the device tree
>>     - platform_reset: reset the platform
>>     - platform_poweroff: poweroff the platform
>>     - platform_quirks: list of quirks for a specific board.
>>
>> Signed-off-by: Julien Grall <julien.grall@linaro.org>
> 
> Acked-by: Ian Campbell <ian.campbell@citrix.com>
> [...]
>> +/* List of possible platform */
>> +static void dump_platform_table(void)
>> +{
>> +    const struct platform_desc *p;
>> +
>> +    printk("Available platform support:\n");
>> +
>> +    for ( p = _splatform; p != _eplatform; p++ )
>> +        printk("    - %s\n", p->name);
>> +}
>> +
>> +int __init platform_init(void)
>> +{
> [...]
>> +    /* We don't have specific operations for this platform */
>> +    if ( platform == _eplatform )
>> +    {
>> +        /* TODO: List compatible */
>> +        printk(XENLOG_WARNING "WARNING: Unrecognized/unsupported device tree "
>> +              "compatible list\n");
>> +        dump_platform_table();
> 
> Looks like the TODO is obsolete?

No. It means we need to print the compatible list of the DTS. Here Xen
only prints which platform is actually supported.
I will update the comment.

-- 
Julien