From mboxrd@z Thu Jan  1 00:00:00 1970
From: Julien Grall <julien.grall@linaro.org>
Subject: Re: [PATCH V4 02/32] xen/mm: Align virtual address on
 PAGE_SIZE in iounmap
Date: Fri, 10 May 2013 17:16:30 +0100
Message-ID: <518D1D5E.6060909@linaro.org>
References: <1368198723-24639-1-git-send-email-julien.grall@linaro.org>
	<1368198723-24639-3-git-send-email-julien.grall@linaro.org>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1368198723-24639-3-git-send-email-julien.grall@linaro.org>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Julien Grall <julien.grall@linaro.org>
Cc: Stefano.Stabellini@eu.citrix.com, keir@xen.org, ian.campbell@citrix.com, patches@linaro.org, xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

On 05/10/2013 04:11 PM, Julien Grall wrote:

> ioremap function can unlikely return an unaligned virtual address if
> the physical address itself is unaligned on a page size.
> 
> Signed-off-by: Julien Grall <julien.grall@linaro.org>
> Acked-by: Jan Beulich <jbeulich@suse.com>
> CC: keir@xen.org
> 
> Changes in v4:
>     - replace vaddr_t by unsigned int
> ---
>  xen/include/xen/vmap.h |    4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/xen/include/xen/vmap.h b/xen/include/xen/vmap.h
> index 88e5d99..45e9870 100644
> --- a/xen/include/xen/vmap.h
> +++ b/xen/include/xen/vmap.h
> @@ -15,7 +15,9 @@ void __iomem *ioremap(paddr_t, size_t);
>  
>  static inline void iounmap(void __iomem *va)
>  {
> -    vunmap((void __force *)va);
> +    unsigned int addr = (unsigned int)(void __force *)va;


Hum I used unsigned int instead of unsigned long. I will resend back
this patch.

> +
> +    vunmap((void *)(addr & PAGE_MASK));
>  }
>  
>  void vm_init(void);


-- 
Julien