From: Stephen Warren <swarren@wwwdotorg.org>
To: Marcin Juszkiewicz <marcin@juszkiewicz.com.pl>
Cc: alsa-devel@alsa-project.org,
Liam Girgwood <liam.r.girdwood@linux.intel.com>,
Luke Yelavich <themuso@ubuntu.com>,
Mark Brown <broonie@kernel.org>,
Peter Robinson <pbrobinson@gmail.com>,
Jordi Mallach <jordi@debian.org>
Subject: Re: [PATCH 5/5] tegraalc5632: add UCM config from Ubuntu
Date: Fri, 10 May 2013 10:22:59 -0600 [thread overview]
Message-ID: <518D1EE3.10205@wwwdotorg.org> (raw)
In-Reply-To: <1368190270-29647-6-git-send-email-marcin@juszkiewicz.com.pl>
On 05/10/2013 06:51 AM, Marcin Juszkiewicz wrote:
> Signed-off-by: Marcin Juszkiewicz <marcin@juszkiewicz.com.pl>
> ---
> tegraalc5632/tegraalc5632.conf | 30 ++++++++++++++++++++++++++++++
I'm not sure that's the correct name for this file.
"alc5632" is the name of the audio CODEC, which could be used in a
variety of different boards, each of which might require a different UCM
configuration. Shouldn't the file be named based on the board name. At
least with upstream kernels, the device tree contains:
nvidia,model = "Compal PAZ00";
which should influence the name the kernel gives to the sound card, and
hence I think be the name the UCM config is looked up under?
> + exec "echo Im setting defaults for tegra-alc5632"
I'm not sure if that's useful?
I also notice that this file doesn't define any use-cases/verbs/...
Presumably a Linux-based OS would expect a certain set of them to exist,
and they'd be implemented/named consistently across all UCM configs?
next prev parent reply other threads:[~2013-05-10 16:23 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-10 12:51 UCM profiles taken from Ubuntu Marcin Juszkiewicz
2013-05-10 12:51 ` [PATCH 1/5] DAISY-I2S: add Samsung ARM Chromebook UCM config from ChromeOS Marcin Juszkiewicz
2013-05-10 12:51 ` [PATCH 2/5] PandaBoard: add UCM config from Ubuntu Marcin Juszkiewicz
2013-05-10 12:51 ` [PATCH 3/5] PandaBoardES: " Marcin Juszkiewicz
2013-05-10 12:51 ` [PATCH 4/5] SDP4430: " Marcin Juszkiewicz
2013-05-10 12:51 ` [PATCH 5/5] tegraalc5632: " Marcin Juszkiewicz
2013-05-10 16:22 ` Stephen Warren [this message]
2013-05-10 20:53 ` Mark Brown
2013-05-11 14:15 ` [PATCH 5/5] tegraalc5632: add UCM config fromUbuntu Marc Dietrich
2013-05-11 14:26 ` Mark Brown
2013-05-11 16:41 ` Leon Romanovsky
2013-05-10 13:17 ` UCM profiles taken from Ubuntu Takashi Iwai
[not found] ` <1368194214.15763.4.camel@penyagolosa.oskuro.net>
2013-05-10 14:22 ` Liam Girdwood
2013-05-10 21:00 ` Mark Brown
2013-05-14 16:14 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=518D1EE3.10205@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=jordi@debian.org \
--cc=liam.r.girdwood@linux.intel.com \
--cc=marcin@juszkiewicz.com.pl \
--cc=pbrobinson@gmail.com \
--cc=themuso@ubuntu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.