From: Eric Nelson <eric.nelson@boundarydevices.com>
To: Fabio Estevam <festevam@gmail.com>
Cc: Fabio Estevam <fabio.estevam@freescale.com>,
alsa-devel@alsa-project.org, lars@metafoo.de,
matt@genesi-usa.com, troy.kisky@boundarydevices.com,
broonie@kernel.org
Subject: Re: [PATCH v5 1/2] ASoC: sgtl5000: Read SGTL5000_CHIP_ID in i2c_probe()
Date: Fri, 10 May 2013 09:37:58 -0700 [thread overview]
Message-ID: <518D2266.4080705@boundarydevices.com> (raw)
In-Reply-To: <1368144947-23775-1-git-send-email-festevam@gmail.com>
On 05/09/2013 05:15 PM, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@freescale.com>
>
> The usual place for reading chip ID is inside i2c_probe, so move it there and
> also convert it to regmap.
>
> sgtl5000_enable_regulators() needs to read the chip revision, so keep the
> revision check there.
>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
> Changes since v4:
> - Just introduced in this version.
>
> sound/soc/codecs/sgtl5000.c | 39 ++++++++++++++++++++++++---------------
> 1 file changed, 24 insertions(+), 15 deletions(-)
>
Tested-by: Eric Nelson <eric.nelson@boundarydevices.com>
prev parent reply other threads:[~2013-05-10 16:38 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-10 0:15 [PATCH v5 1/2] ASoC: sgtl5000: Read SGTL5000_CHIP_ID in i2c_probe() Fabio Estevam
2013-05-10 0:15 ` [PATCH v5 2/2] ASoC: sgtl5000: Fix driver probe after reset Fabio Estevam
2013-05-10 1:17 ` Troy Kisky
2013-05-10 2:12 ` Fabio Estevam
[not found] ` <CAKGA1bnhE3dZe8P+aJm+cps+Rp4abSGOMmPckGw_0fCnh9e6+A@mail.gmail.com>
2013-05-10 17:31 ` Fabio Estevam
2013-05-10 19:11 ` Troy Kisky
2013-05-10 19:16 ` Troy Kisky
2013-05-10 19:18 ` Fabio Estevam
2013-05-10 19:39 ` Fabio Estevam
2013-05-10 20:56 ` Mark Brown
2013-05-10 20:58 ` Mark Brown
2013-05-10 20:13 ` Troy Kisky
2013-05-10 19:23 ` Fabio Estevam
2013-05-10 9:16 ` Mark Brown
2013-05-10 16:38 ` Eric Nelson
2013-05-10 20:59 ` Mark Brown
2013-05-10 9:15 ` [PATCH v5 1/2] ASoC: sgtl5000: Read SGTL5000_CHIP_ID in i2c_probe() Mark Brown
2013-05-10 16:37 ` Eric Nelson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=518D2266.4080705@boundarydevices.com \
--to=eric.nelson@boundarydevices.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=fabio.estevam@freescale.com \
--cc=festevam@gmail.com \
--cc=lars@metafoo.de \
--cc=matt@genesi-usa.com \
--cc=troy.kisky@boundarydevices.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.