All of lore.kernel.org
 help / color / mirror / Atom feed
From: Doug Nazar <nazard@nazar.ca>
To: autofs@vger.kernel.org
Subject: get_proximity() crashes on interfaces with no addresses
Date: Sun, 12 May 2013 11:48:44 -0400	[thread overview]
Message-ID: <518FB9DC.3000304@nazar.ca> (raw)

[-- Attachment #1: Type: text/plain, Size: 249 bytes --]

Since commit aa6f7793 [autofs-5.0.7 - fix ipv6 proximity calculation] 
uses getifaddrs however it crashes on interfaces with no addresses. Fix 
the NULL check to ignore interfaces with no addresses.

Should it also check for the IFF_UP flag?

Doug


[-- Attachment #2: autofs-5.0.7-fix-interface-address-null-check.patch --]
[-- Type: text/plain, Size: 667 bytes --]

diff -ur autofs-5.0.7.orig/modules/replicated.c autofs-5.0.7/modules/replicated.c
--- autofs-5.0.7.orig/modules/replicated.c	2013-05-10 04:48:32.000000000 -0400
+++ autofs-5.0.7/modules/replicated.c	2013-05-10 04:50:07.000000000 -0400
@@ -166,7 +166,7 @@
 	this = ifa;
 	while (this) {
 		if (this->ifa_flags & IFF_POINTOPOINT ||
-		    this->ifa_addr->sa_data == NULL) {
+		    this->ifa_addr == NULL) {
 			this = this->ifa_next;
 			continue;
 		}
@@ -203,7 +203,7 @@
 	this = ifa;
 	while (this) {
 		if (this->ifa_flags & IFF_POINTOPOINT ||
-		    this->ifa_addr->sa_data == NULL) {
+		    this->ifa_addr == NULL) {
 			this = this->ifa_next;
 			continue;
 		}

             reply	other threads:[~2013-05-12 15:48 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-12 15:48 Doug Nazar [this message]
2013-05-12 18:26 ` get_proximity() crashes on interfaces with no addresses Leonardo Chiquitto
2013-05-12 20:31   ` Doug Nazar
2013-05-14  4:13     ` Ian Kent
2013-05-14  9:15       ` Doug Nazar
2013-05-16  0:45         ` Ian Kent

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=518FB9DC.3000304@nazar.ca \
    --to=nazard@nazar.ca \
    --cc=autofs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.