All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bo Shen <voice.shen@atmel.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [Patch v2 1/4] USB: ohci-at91: support sama5d3x devices
Date: Mon, 13 May 2013 14:30:23 +0800	[thread overview]
Message-ID: <5190887F.3070800@atmel.com> (raw)
In-Reply-To: <518F7CD0.8090701@googlemail.com>

Hi Andreas,

On 5/12/2013 19:28, Andreas Bie?mann wrote:
> Dear Bo Shen,
>
> On 12.03.2013 07:15, Bo Shen wrote:
>> Add OHCI support for sama5d3x devices
>
> can you please rebase this patch and send again?

OK, I will do it at next version.

>>
>> Signed-off-by: Bo Shen <voice.shen@atmel.com>
>> ---
>> change in v2:
>>    - change #if defined to #ifdef for sama5d3
>> ---
>>   drivers/usb/host/ohci-at91.c |   14 ++++++++++++--
>>   1 file changed, 12 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/usb/host/ohci-at91.c b/drivers/usb/host/ohci-at91.c
>> index efd711d..086cd0f 100644
>> --- a/drivers/usb/host/ohci-at91.c
>> +++ b/drivers/usb/host/ohci-at91.c
>> @@ -42,7 +42,7 @@ int usb_cpu_init(void)
>>       while ((readl(&pmc->sr) & AT91_PMC_LOCKB) != AT91_PMC_LOCKB)
>>           ;
>>   #elif defined(CONFIG_AT91SAM9G45) || defined(CONFIG_AT91SAM9M10G45)
>> || \
>> -    defined(CONFIG_AT91SAM9X5)
>> +    defined(CONFIG_AT91SAM9X5) || defined(CONFIG_SAMA5D3)
>>       /* Enable UPLL */
>>       writel(readl(&pmc->uckr) | AT91_PMC_UPLLEN | AT91_PMC_BIASEN,
>>           &pmc->uckr);
>> @@ -54,7 +54,12 @@ int usb_cpu_init(void)
>>   #endif
>>
>>       /* Enable USB host clock. */
>> +#ifdef CONFIG_SAMA5D3
>> +    writel(1 << (ATMEL_ID_UHP - 32), &pmc->pcer1);
>
> Please reorder the patches so that pmc->pcer1 is declared before used.

Ok, thanks for figure out this. I will do it at next version.

> Best regards
>
> Andreas Bie?mann

Best Regards,
Bo Shen

  reply	other threads:[~2013-05-13  6:30 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-12  6:15 [U-Boot] [Patch v2 0/4] ARM: atmel: add sama5d3xek board support Bo Shen
2013-03-12  6:15 ` [U-Boot] [Patch v2 1/4] USB: ohci-at91: support sama5d3x devices Bo Shen
2013-05-12 11:28   ` Andreas Bießmann
2013-05-13  6:30     ` Bo Shen [this message]
2013-03-12  6:15 ` [U-Boot] [Patch v2 2/4] NET: macb: " Bo Shen
2013-05-12 11:33   ` Andreas Bießmann
2013-05-13 21:31     ` Joe Hershberger
2013-05-22  8:45       ` Bo Shen
2013-05-23  6:51         ` Andreas Bießmann
2013-05-23 21:58           ` Joe Hershberger
2013-06-17  1:11             ` Bo Shen
2013-06-17  2:27               ` Joe Hershberger
2013-05-24  1:11           ` Bo Shen
2013-03-12  6:15 ` [U-Boot] [Patch v2 3/4] SPI: atmel_spi: " Bo Shen
2013-05-12 11:30   ` Andreas Bießmann
2013-03-12  6:15 ` [U-Boot] [Patch v2 4/4] ARM: atmel: add sama5d3xek support Bo Shen
2013-05-12 11:35   ` Andreas Bießmann
2013-05-13  6:28     ` Bo Shen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5190887F.3070800@atmel.com \
    --to=voice.shen@atmel.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.