Re: [PATCH] Make sure to use tools as found by configure

[Christoph Egger <chegger@amazon.de>]

On 13.05.13 11:51, Ian Campbell wrote:
> On Fri, 2013-05-10 at 18:10 +0100, Matt Wilson wrote:
>> On Fri, May 10, 2013 at 01:59:53PM +0200, Christoph Egger wrote:
>>>
>>> Hi,
>>>
>>> attached patch makes the build process work as described at
>>> http://wiki.xen.org/wiki/Compiling_Xen_From_Source_on_NetBSD
>>>
>>> Without this patch compiling the xen kernel fails with
>>> python: No such file or directory
>>>
>>> Note, this patch enforces to run configure before you
>>> can compile the xen kernel.
>>> This is already required to build tools and stubdom anyway.
>>>
>>> This makes an other patch work as submitted:
>>> http://lists.xen.org/archives/html/xen-devel/2013-04/msg02098.html
>>>
>>> Christoph
>>>
>>>
>>> commit 7172e6e0020328d14638a0bbb66a52c905cb4b0b
>>> Author: Christoph Egger <chegger@amazon.de>
>>> Date:   Thu Feb 7 14:29:19 2013 +0000
>>>
>>>     Make sure to use tools as found by configure.
>>>     Fold inclusion of Tools.mk into toplevel Config.mk.
>>>
>>>     Signed-off-by: Christoph Egger <chegger@amazon.de>
>>>     Reviewed-by: Matthew Wilson <msw@amazon.com>
>>
>> To be clear, I Nack'ed this in review and gave two options:
> 
> I was about to query this, thanks for clarifying.
> 
> Christoph, please be more careful in future not to misrepresent peoples
> review.
> 
> In general I would think it a good idea if Reviewed-by tags are posted
> publicly by the Reviewer on xen-devel, even if the review was carried
> out internally prior to posting, this would help avoid this sort of
> issue. Not a rule I don't think, but would help avoid mistakes...

Understood.

Christoph