From mboxrd@z Thu Jan  1 00:00:00 1970
From: Christoph Egger <chegger@amazon.de>
Subject: Re: [PATCH 2/2] Xen/vMCE: bugfix to remove problematic
 is_vmce_ready check
Date: Mon, 13 May 2013 13:09:53 +0200
Message-ID: <5190CA01.9010505@amazon.de>
References: <DE8DF0795D48FD4CA783C40EC8292335460033@SHSMSX101.ccr.corp.intel.com>
	<DE8DF0795D48FD4CA783C40EC8292335466071@SHSMSX101.ccr.corp.intel.com>
	<51876FD4.9080006@amazon.de>
	<51878E9A02000078000D36C8@nat28.tlf.novell.com>
	<DE8DF0795D48FD4CA783C40EC82923358D9A05@SHSMSX102.ccr.corp.intel.com>
	<51877AB0.1060802@amazon.de>
	<DE8DF0795D48FD4CA783C40EC82923358D9A3E@SHSMSX102.ccr.corp.intel.com>
	<51879645.8080803@amazon.de>
	<DE8DF0795D48FD4CA783C40EC82923358D9F52@SHSMSX102.ccr.corp.intel.com>
	<5187C6DE.2020304@amazon.de>
	<DE8DF0795D48FD4CA783C40EC82923358DA006@SHSMSX102.ccr.corp.intel.com>
	<5187CCD9.9030801@amazon.de>
	<DE8DF0795D48FD4CA783C40EC82923358DB152@SHSMSX102.ccr.corp.intel.com>
	<5188E8D1.7060009@amazon.de>
	<DE8DF0795D48FD4CA783C40EC82923358E9691@SHSMSX101.ccr.corp.intel.com>
	<518CFD26.7070200@amazon.de>
	<DE8DF0795D48FD4CA783C40EC82923358EA947@SHSMSX101.ccr.corp.intel.com>
	<5190A7B8.7020002@amazon.de>
	<DE8DF0795D48FD4CA783C40EC82923358EB8A1@SHSMSX101.ccr.corp.intel.co!
	m>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <DE8DF0795D48FD4CA783C40EC82923358EB8A1@SHSMSX101.ccr.corp.intel.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: "Liu, Jinsong" <jinsong.liu@intel.com>
Cc: Jan Beulich <JBeulich@suse.com>, xen-devel <xen-devel@lists.xen.org>
List-Id: xen-devel@lists.xenproject.org

On 13.05.13 12:44, Liu, Jinsong wrote:
>>> Please refer to the description of patch 2/2, especially
>>>
>>>     * For dom0, if really need check, it should check whether vMCE
>>>     injection for dom0 ready (say, exception trap bounce check, which
>>>     has been done at inject_vmce()), not check dom0 mcelog ready
>>>     (which has been done at mce_softirq() before send global virq to
>>> dom0). 
>>>
>>> Which means before hypervisor send error log via virq to dom0,
>>> current code has checked whether mcelog ready at dom0 or not -->
>>> that's the right place for your concern, and it has indeed done
>>> check. 
>>
>> I think, I do not understand the patch description.
>> Let me rephrase if I do now due to this discussion:
>>
>> The mcelog driver in Dom0 registers itself to the virq handler to
>> provide the machine check logging service.
> 
> Yes.
> 
>> Xen checks if a virq handler has been registered 
> 
> Yes.
> 
>> but does not check
>> if the dom0 handler is actually ready to take the errors.
>> This patch fixes this.
>>
> 
> I'm not clear your question 'does not check if the dom0 handler
> is actually ready to take the errors'. Could you elaborate more your
concern at this point?

Yes, this is exactly my question. You got it.

Christoph