From: Wido den Hollander <wido@42on.com>
To: "ceph-devel@vger.kernel.org" <ceph-devel@vger.kernel.org>
Subject: RBD image format in rbd_stat()
Date: Mon, 13 May 2013 13:55:48 +0200 [thread overview]
Message-ID: <5190D4C4.6060400@42on.com> (raw)
Hi,
While implementing the RADOS/RBD Java bindings for usage in CloudStack I
stumbled upon the problem of finding out if a RBD image is format 1 or
2, due to snapshotting and layering.
I found out that rbd_image_t doesn't contain a field "format", and you
gave to use rbd_get_old_format() to find out if a image is format 1 or 2.
rbd_stat however also has a size parameter which isn't used right now
when looking at the librbd code.
Couldn't a 'format' field be added to rbd_image_t and maintain backwards
compatibility by actually looking at the size parameter? That wouldn't
break any existing code.
--
Wido den Hollander
42on B.V.
Phone: +31 (0)20 700 9902
Skype: contact42on
reply other threads:[~2013-05-13 11:55 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5190D4C4.6060400@42on.com \
--to=wido@42on.com \
--cc=ceph-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.