Re: [PATCH v2] docs: make 'gmake dist-docs' work

[Christoph Egger <chegger@amazon.de>]

On 13.05.13 13:34, Ian Campbell wrote:
> On Mon, 2013-05-13 at 12:25 +0100, Christoph Egger wrote:
>> On 13.05.13 12:44, Ian Campbell wrote:
>>> On Fri, 2013-05-10 at 15:07 +0100, Christoph Egger wrote:
>>>> doc: buildsystem fixes
>>>>
>>>> - use correct pathes (make gmake dist-docs from toplevel directory work)
>>>
>>> This ("make dist-docs") seems to work for me, how does it fail for you?
>>
>> On the toplevel directory '../xen' and '../config' point to
>> non-existent directories.
>> On the toplevel directory './gen-html-index' does not exist.
> 
> I'm confused. By toplevel you mean "xen.git" and not "xen.git/docs",
> right?

Yes.

> make dist-docs turns into "make -C docs install" (with DESTDIR set) so
> at the time ../xen or ../config are evaluated you should be in
> xen.git/docs.
>
> Or are you saying that you are extracting the docs subdir out to
> elsewhere? Perhaps you are doing an out of tree build or something else
> complex?

No.
My build procedure is:

- run configure
- gmake -jN dist-xen
- gmake -jN dist-tools
- gmake dist-docs

> I'm not suggesting your changes are wrong. I'd just like to understand
> the breakage...

I retried w/o my patch to get the error message:

xen.git$ gmake dist-docs
[...]
./xen-headers -O html/hypercall \
        -T 'arch-x86_64 - Xen public headers' \
        -X arch-x86_32 -X xen-x86_32 -X arch-arm \
        ../xen include/public include/xen/errno.h
gmake[1]: ./xen-headers: Command not found
gmake[1]: *** [html/hypercall/index.html] Error 127
gmake[1]: Leaving directory `/home/chegger/xen.git/docs'
gmake: *** [install-docs] Error 2
xen.git$

Since I am on the toplevel directory (or the shell at least)
calling ./xen-headers can't be found, of course. That's my thinking.

I also made general cleanup to make 'docs' consistent with the
other parts of the buildsystem.

Christoph