Re: [Qemu-devel] [PATCH] blockdev: Rename BlockdevAction -> TransactionAction

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1120 bytes --]

On 05/13/2013 02:46 AM, Kevin Wolf wrote:
> There's no reason to restrict transactions to operations related to
> block devices, so rename the type now before schema introspection stops
> us from doing so.
> 
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> ---
>  blockdev.c       | 22 +++++++++++-----------
>  qapi-schema.json |  8 ++++----
>  2 files changed, 15 insertions(+), 15 deletions(-)

Reviewed-by: Eric Blake <eblake@redhat.com>

However,

>  #
>  #  List of:
> -#  @BlockdevAction: information needed for the device snapshot
> +#  @TransactionAction: information needed for the device snapshot

Is this comment now out of date?

>  #
>  # Returns: nothing on success
>  #          If @device is not a valid block device, DeviceNotFound
> @@ -1640,7 +1640,7 @@
>  # Since 1.1
>  ##
>  { 'command': 'transaction',
> -  'data': { 'actions': [ 'BlockdevAction' ] } }
> +  'data': { 'actions': [ 'TransactionAction' ] } }
>  
>  ##
>  # @blockdev-snapshot-sync
> 

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 621 bytes --]