From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Egger Subject: Re: [PATCH v2] docs: make 'gmake dist-docs' work Date: Mon, 13 May 2013 14:59:36 +0200 Message-ID: <5190E3B8.60108@amazon.de> References: <518CFF30.8070402@amazon.de> <1368441887.537.49.camel@zakaz.uk.xensource.com> <5190CDC3.7030502@amazon.de> <1368444872.537.78.camel@zakaz.uk.xensource.com> <5190D88D.2020005@amazon.de> <1368447838.537.96.camel@zakaz.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1368447838.537.96.camel@zakaz.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: xen-devel List-Id: xen-devel@lists.xenproject.org On 13.05.13 14:23, Ian Campbell wrote: > On Mon, 2013-05-13 at 13:11 +0100, Christoph Egger wrote: >> On 13.05.13 13:34, Ian Campbell wrote: >>> On Mon, 2013-05-13 at 12:25 +0100, Christoph Egger wrote: >>>> On 13.05.13 12:44, Ian Campbell wrote: >>>>> On Fri, 2013-05-10 at 15:07 +0100, Christoph Egger wrote: >>>>>> doc: buildsystem fixes >>>>>> >>>>>> - use correct pathes (make gmake dist-docs from toplevel directory work) >>>>> >>>>> This ("make dist-docs") seems to work for me, how does it fail for you? >>>> >>>> On the toplevel directory '../xen' and '../config' point to >>>> non-existent directories. >>>> On the toplevel directory './gen-html-index' does not exist. >>> >>> I'm confused. By toplevel you mean "xen.git" and not "xen.git/docs", >>> right? >> >> Yes. >> >>> make dist-docs turns into "make -C docs install" (with DESTDIR set) so >>> at the time ../xen or ../config are evaluated you should be in >>> xen.git/docs. >>> >>> Or are you saying that you are extracting the docs subdir out to >>> elsewhere? Perhaps you are doing an out of tree build or something else >>> complex? >> >> No. >> My build procedure is: >> >> - run configure >> - gmake -jN dist-xen >> - gmake -jN dist-tools >> - gmake dist-docs >> >>> I'm not suggesting your changes are wrong. I'd just like to understand >>> the breakage... >> >> I retried w/o my patch to get the error message: >> >> xen.git$ gmake dist-docs >> [...] >> ./xen-headers -O html/hypercall \ >> -T 'arch-x86_64 - Xen public headers' \ >> -X arch-x86_32 -X xen-x86_32 -X arch-arm \ >> ../xen include/public include/xen/errno.h >> gmake[1]: ./xen-headers: Command not found >> gmake[1]: *** [html/hypercall/index.html] Error 127 >> gmake[1]: Leaving directory `/home/chegger/xen.git/docs' >> gmake: *** [install-docs] Error 2 >> xen.git$ >> >> Since I am on the toplevel directory (or the shell at least) >> calling ./xen-headers can't be found, of course. That's my thinking. > > I think you are mistaken, since the > Leaving directory `/home/chegger/xen.git/docs' > tells us that gmake previously entered this directory. That is how make > (not just gmake) normally operates and is what "make -C docs" does. > > Prior to your recent patch the invocation of ./xen-headers was via: > perl -w -- ./gen-html-index > Which is not consistent with your logs above. Do you have some other > local patches which remove the "perl -w -- " prefix? No, there is no other local patch in docs/ Same lines with my patch: /usr/pkg/bin/perl -w /home/chegger/xen.git/docs/xen-headers -O html/hypercall \ -T 'arch-x86_64 - Xen public headers' \ -X arch-x86_32 -X xen-x86_32 -X arch-arm \ /home/chegger/xen.git/docs/../xen include/public include/xen/errno.h /usr/pkg/bin/perl -w -- /home/chegger/xen.git/docs/gen-html-index -i INDEX html html/misc/hvm-emulated-unplug.html html/misc/xl-numa-placement.html html/misc/efi.html html/misc/qemu-upstream_howto_use_it.html html/misc/xl-network-configuration.html html/misc/xen-command-line.html html/misc/xenstore-paths.html html/misc/coverage.html html/man/xm.1.html html/man/xl.1.html html/man/xl.conf.5.html html/man/xend-config.sxp.5.html html/man/xl.cfg.5.html html/man/xmdomain.cfg.5.html html/man/xlcpupool.cfg.5.html html/misc/dump-core-format.txt html/misc/kexec_and_kdump.txt html/misc/grant-tables.txt html/misc/xenpaging.txt html/misc/vtpm.txt html/misc/xen-error-handling.txt html/misc/xsm-flask.txt html/misc/console.txt html/misc/vtd.txt html/misc/distro_mapping.txt html/misc/libxl_memory.txt html/ misc/crashdb.txt html/misc/xl-disk-configuration.txt html/misc/sedf_scheduler_mini-HOWTO.txt html/misc/xenstore.txt html/misc/vbd-interface.txt html/misc/tscmode.txt html/hypercall/index.ht! ml > If you cropped it from the logs by mistake then the "Command not found" > likely refers to "perl" and not "./xen-headers". > > If you are trying to execute ./gen-html-index directly then the "Command > not found" might be down to the shebang in the script which refers > to /usr/bin/perl, which doesn't exist for you. Yes, make configure to define $(PERL) is the real fix as Tim stated out in the other mail. > On Linux that would come out as "Bad interpreter", but NetBSD may differ > I suppose. More likely a difference to the korn-shell: xen.git/docs$ ./xen-headers ksh: ./xen-headers: No such file or directory xen.git/docs$ ./gen-html-index ksh: ./gen-html-index: cannot execute - Permission denied xen.git/docs$ Christoph