All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Sandeen <sandeen@redhat.com>
To: xfs-oss <xfs@oss.sgi.com>
Subject: [PATCH, RFC] xfstests: fail test if it causes a kernel taint
Date: Mon, 13 May 2013 16:55:18 -0500	[thread overview]
Message-ID: <51916146.80308@redhat.com> (raw)

This should, in theory, fail a test if it introduces one of
a handful of "serious" kernel taints.  I mask on a few taint
values because using an out of tree module or a non-GPL module
should never fail a test, for example.

Signed-off-by: Eric Sandeen <sandeen@redhat.com>
---

diff --git a/check b/check
index a79747e..a9cac4e 100755
--- a/check
+++ b/check
@@ -446,6 +445,11 @@ do
 	fi
 	rm -f core $seqres.notrun
 
+	if [ "$HOSTOS" == "Linux" ]; then
+		tainted=`sysctl -n kernel.tainted`
+		let "tainted &= $TAINT_FAIL"
+	fi
+
 	start=`_wallclock`
 	$timestamp && echo -n "	["`date "+%T"`"]"
 	[ ! -x $seq ] && chmod u+x $seq # ensure we can run it
@@ -507,6 +511,19 @@ do
 			 "entire diff)"
 		    err=true
 		fi
+
+		# See if this run tainted the kernel due to oops, etc
+		if [ "$HOSTOS" == "Linux" ]
+		then
+			tainted2=`sysctl -n kernel.tainted`
+			let "tainted2 &= $TAINT_FAIL"
+			if [ "$tainted" != "$tainted2" ]
+			then
+				echo " Kernel taint changed from $tainted to $tainted2."
+				echo " See dmesg for details."
+				err=true
+			fi
+		fi
 	    fi
 	fi
 
diff --git a/common/config b/common/config
index 67c1498..6483ded 100644
--- a/common/config
+++ b/common/config
@@ -82,6 +82,15 @@ export PWD=`pwd`
 export MALLOCLIB=${MALLOCLIB:=/usr/lib/libefence.a}
 export LOCAL_CONFIGURE_OPTIONS=${LOCAL_CONFIGURE_OPTIONS:=--enable-readline=yes}
 
+# kernel taint values on Linux (from kernel.taint sysctl)
+TAINT_MACHINE_CHECK=16
+TAINT_BAD_PAGE=32
+TAINT_DIED=128
+TAINT_WARNING=512
+# If a test introduces one of these taints we consider it to have failed
+let "TAINT_FAIL=( $TAINT_MACHINE_CHECK | $TAINT_BAD_PAGE | $TAINT_DIED | $TAINT_WARNING )"
+export TAINT_FAIL
+
 # $1 = prog to look for, $2* = default pathnames if not found in $PATH
 set_prog_path()
 {

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

             reply	other threads:[~2013-05-13 21:55 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-13 21:55 Eric Sandeen [this message]
2013-05-14  1:15 ` [PATCH, RFC] xfstests: fail test if it causes a kernel taint Dave Chinner
2013-05-14  2:00   ` Eric Sandeen
2013-05-14  3:15     ` Dave Chinner
2013-05-14  3:38       ` Eric Sandeen
2013-05-23 15:47 ` [PATCH, V2] " Eric Sandeen
2013-10-10  3:16   ` Eric Sandeen
2017-07-28 16:43   ` Eric Sandeen
2017-07-31  1:57     ` Eryu Guan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51916146.80308@redhat.com \
    --to=sandeen@redhat.com \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.