All of lore.kernel.org
 help / color / mirror / Atom feed
From: Huang Shijie <b32955@freescale.com>
To: Vikram Narayanan <vikram186@gmail.com>
Cc: Stefan Roese <sr@denx.de>, linux-mtd@lists.infradead.org
Subject: Re: mtd_oobtest fails with GPMI-NAND
Date: Tue, 14 May 2013 10:23:51 +0800	[thread overview]
Message-ID: <5191A037.6060002@freescale.com> (raw)
In-Reply-To: <51911A2E.1060903@gmail.com>

于 2013年05月14日 00:51, Vikram Narayanan 写道:
> Hello Huang,
>
> On 5/13/2013 2:31 PM, Huang Shijie wrote:
>>>
>>> Huang, is this to be expected? How does this look on one of your
>>> officially "supported" imx6 boards with NAND support?
>>>
>> I suggest you do not use the mtd_nandbiterrs.ko. It will call the
>> mtd_write_oob() which will definitely lead to the
>> -EBADMSG (-74) error.
>>
>> The mtd_write_oob() in mtd_nandbiterrs.ko writes a whole page without
>> enabling the BCH to do the hardware ECC.
>> But mtd_read() in mtd_nandbiterrs.ko DOES do the hardware ECC by the 
>> BCH.
>> It's normal that you meet -74.
>
> I wonder if this has something to do with the fake
> "struct nand_ecclayout" defined in
> <drivers/mtd/nand/gpmi-nand/gpmi-nand.c>?
it's not a fake structure, i think.

We do use all the oob now.
>
> Could you please explain on what is the technical restriction for not 
> providing a _sane_ ecclayout structure, so that the mtd_tests run 
> happily?
>
could you please read the chapter about the BCH, especially the "Flash 
Page Layout".

The reason why We use all the oob is that we can not get the correct ECC 
info from the nand, such as "4 bits for 512 byte".
I have sent a patch set with whitch we can parse out some ECC info for 
ONFI nand and full-id nand.

The gpmi-nand does not live for mtd_tests. If it can not pass some 
mtd_tests, it does not mean the gpmi has bugs.



thanks
Huang Shijie



> Regards,
> Vikram
>

  reply	other threads:[~2013-05-14  2:22 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-18 16:52 mtd_oobtest fails with GPMI-NAND Vikram Narayanan
2013-01-21  2:12 ` Huang Shijie
2013-01-28  2:39   ` Vikram Narayanan
2013-01-28  3:20     ` Huang Shijie
2013-01-28 17:04       ` Vikram Narayanan
2013-01-29  2:06         ` Huang Shijie
2013-01-29  2:26           ` Vikram Narayanan
2013-01-29  2:36             ` Huang Shijie
2013-01-29 16:28               ` Vikram Narayanan
2013-01-30  2:27                 ` Huang Shijie
2013-02-02  6:41                   ` Vikram Narayanan
2013-02-02  7:42                     ` Huang Shijie
2013-02-02  7:46                       ` Huang Shijie
2013-05-08 14:33                     ` Stefan Roese
2013-05-09 12:30                       ` Vikram Narayanan
2013-05-10  6:20                         ` Stefan Roese
2013-05-12 12:10                           ` Vikram Narayanan
2013-05-12 15:09                             ` Stefan Roese
2013-05-13 16:38                               ` Vikram Narayanan
2013-05-13  2:51                           ` Huang Shijie
2013-05-13  8:01                             ` Stefan Roese
2013-05-13  9:01                               ` Huang Shijie
2013-05-13  9:22                                 ` Stefan Roese
2013-05-13  9:34                                   ` Huang Shijie
2013-05-13 10:02                                     ` Stefan Roese
2013-05-14  2:09                                       ` Huang Shijie
2013-05-14  2:11                                       ` Huang Shijie
2013-05-13 16:51                                 ` Vikram Narayanan
2013-05-14  2:23                                   ` Huang Shijie [this message]
2013-05-14  2:33                                     ` Vikram Narayanan
2013-05-14  2:47                                       ` Huang Shijie
2013-05-13 16:43                               ` Vikram Narayanan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5191A037.6060002@freescale.com \
    --to=b32955@freescale.com \
    --cc=linux-mtd@lists.infradead.org \
    --cc=sr@denx.de \
    --cc=vikram186@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.