Re: [Qemu-devel] [PATCH 2/3] include/elf.h: add aarch64 ELF machine and relocs

[Claudio Fontana <claudio.fontana@huawei.com>]

On 13.05.2013 20:34, Peter Maydell wrote:
> On 13 May 2013 14:31, Claudio Fontana <claudio.fontana@huawei.com> wrote:
>>
>> we will use the 26bit relative relocations in the aarch64 tcg target.
> 
> This patch looks OK, but can I ask you to just neaten up
> the #defines by making the column of values line up?
> (use spaces, not hardcoded tabs).
> 
>> @@ -616,6 +618,132 @@ typedef struct {
>>  /* Keep this the last entry.  */
>>  #define R_ARM_NUM              256
> 
> It's kind of obvious that we're doing aarch64 relocs from
> here on, but it would be nice to just put a comment
> here to explicitly separate the aarch64 relocs from the
> 32 bit ARM ones:
> 
> /* ARM AArch64 relocation types */
> 
>> +#define R_AARCH64_NONE          256 /* also accept R_ARM_NONE (0) as null */
>> +/* static data relocations */
>> +#define R_AARCH64_ABS64         257
>> +#define R_AARCH64_ABS32         258
> 
> thanks
> -- PMM
> 

I agree with your comments above, will change accordingly.

-- 
Claudio Fontana