From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maxime Ripard Subject: Re: [PATCH 06/14] ARM: bcm281xx: Remove init_irq declaration in machine description Date: Tue, 14 May 2013 10:25:39 +0200 Message-ID: <5191F503.2070301@free-electrons.com> References: <1368438253-28218-1-git-send-email-maxime.ripard@free-electrons.com> <1368438253-28218-7-git-send-email-maxime.ripard@free-electrons.com> <519147C6.6080004@broadcom.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <519147C6.6080004@broadcom.com> Sender: linux-sh-owner@vger.kernel.org To: Christian Daudt Cc: Michal Simek , Linus Walleij , Jamie Iles , Simon Horman , Magnus Damm , Viresh Kumar , David Brown , Jason Cooper , Andrew Lunn , Gregory Clement , Shawn Guo , Barry Song , Tony Prisk , linux-arm-kernel@lists.infradead.org, linux-sh@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, Arnd Bergmann , Olof Johansson List-Id: linux-arm-msm@vger.kernel.org Hi Christian, Le 13/05/2013 22:06, Christian Daudt a =E9crit : > On 13-05-13 02:44 AM, Maxime Ripard wrote: >> Commit ebafed7a ("ARM: irq: Call irqchip_init if no init_irq functio= n is >> specified") removed the need to explictly setup the init_irq field i= n >> the machine description when using only irqchip_init. Remove that >> declaration for bcm281xx as well. >> >> Signed-off-by: Maxime Ripard >> --- >> arch/arm/mach-bcm/board_bcm.c | 1 - >> 1 file changed, 1 deletion(-) >> >> diff --git a/arch/arm/mach-bcm/board_bcm.c >> b/arch/arm/mach-bcm/board_bcm.c >> index 22e8421..24556cf 100644 >> --- a/arch/arm/mach-bcm/board_bcm.c >> +++ b/arch/arm/mach-bcm/board_bcm.c >> @@ -54,7 +54,6 @@ static void __init board_init(void) >> static const char * const bcm11351_dt_compat[] =3D { "bcm,bcm11351= ", >> NULL, }; >> DT_MACHINE_START(BCM11351_DT, "Broadcom Application Processor") >> - .init_irq =3D irqchip_init, >> .init_time =3D clocksource_of_init, >> .init_machine =3D board_init, >> .dt_compat =3D bcm11351_dt_compat, > Acked-by: Christian Daudt Thanks! I forgot to remove the include of irqchip.h into all these patches, so I'll send a v2, and I guess you could probably merge it through your tree after that directly. Maxime --=20 Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maxime Ripard Date: Tue, 14 May 2013 08:25:39 +0000 Subject: Re: [PATCH 06/14] ARM: bcm281xx: Remove init_irq declaration in machine description Message-Id: <5191F503.2070301@free-electrons.com> List-Id: References: <1368438253-28218-1-git-send-email-maxime.ripard@free-electrons.com> <1368438253-28218-7-git-send-email-maxime.ripard@free-electrons.com> <519147C6.6080004@broadcom.com> In-Reply-To: <519147C6.6080004@broadcom.com> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable To: linux-arm-kernel@lists.infradead.org Hi Christian, Le 13/05/2013 22:06, Christian Daudt a =E9crit : > On 13-05-13 02:44 AM, Maxime Ripard wrote: >> Commit ebafed7a ("ARM: irq: Call irqchip_init if no init_irq function is >> specified") removed the need to explictly setup the init_irq field in >> the machine description when using only irqchip_init. Remove that >> declaration for bcm281xx as well. >> >> Signed-off-by: Maxime Ripard >> --- >> arch/arm/mach-bcm/board_bcm.c | 1 - >> 1 file changed, 1 deletion(-) >> >> diff --git a/arch/arm/mach-bcm/board_bcm.c >> b/arch/arm/mach-bcm/board_bcm.c >> index 22e8421..24556cf 100644 >> --- a/arch/arm/mach-bcm/board_bcm.c >> +++ b/arch/arm/mach-bcm/board_bcm.c >> @@ -54,7 +54,6 @@ static void __init board_init(void) >> static const char * const bcm11351_dt_compat[] =3D { "bcm,bcm11351", >> NULL, }; >> DT_MACHINE_START(BCM11351_DT, "Broadcom Application Processor") >> - .init_irq =3D irqchip_init, >> .init_time =3D clocksource_of_init, >> .init_machine =3D board_init, >> .dt_compat =3D bcm11351_dt_compat, > Acked-by: Christian Daudt Thanks! I forgot to remove the include of irqchip.h into all these patches, so I'll send a v2, and I guess you could probably merge it through your tree after that directly. Maxime --=20 Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com From mboxrd@z Thu Jan 1 00:00:00 1970 From: maxime.ripard@free-electrons.com (Maxime Ripard) Date: Tue, 14 May 2013 10:25:39 +0200 Subject: [PATCH 06/14] ARM: bcm281xx: Remove init_irq declaration in machine description In-Reply-To: <519147C6.6080004@broadcom.com> References: <1368438253-28218-1-git-send-email-maxime.ripard@free-electrons.com> <1368438253-28218-7-git-send-email-maxime.ripard@free-electrons.com> <519147C6.6080004@broadcom.com> Message-ID: <5191F503.2070301@free-electrons.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Christian, Le 13/05/2013 22:06, Christian Daudt a ?crit : > On 13-05-13 02:44 AM, Maxime Ripard wrote: >> Commit ebafed7a ("ARM: irq: Call irqchip_init if no init_irq function is >> specified") removed the need to explictly setup the init_irq field in >> the machine description when using only irqchip_init. Remove that >> declaration for bcm281xx as well. >> >> Signed-off-by: Maxime Ripard >> --- >> arch/arm/mach-bcm/board_bcm.c | 1 - >> 1 file changed, 1 deletion(-) >> >> diff --git a/arch/arm/mach-bcm/board_bcm.c >> b/arch/arm/mach-bcm/board_bcm.c >> index 22e8421..24556cf 100644 >> --- a/arch/arm/mach-bcm/board_bcm.c >> +++ b/arch/arm/mach-bcm/board_bcm.c >> @@ -54,7 +54,6 @@ static void __init board_init(void) >> static const char * const bcm11351_dt_compat[] = { "bcm,bcm11351", >> NULL, }; >> DT_MACHINE_START(BCM11351_DT, "Broadcom Application Processor") >> - .init_irq = irqchip_init, >> .init_time = clocksource_of_init, >> .init_machine = board_init, >> .dt_compat = bcm11351_dt_compat, > Acked-by: Christian Daudt Thanks! I forgot to remove the include of irqchip.h into all these patches, so I'll send a v2, and I guess you could probably merge it through your tree after that directly. Maxime -- Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com