From: Chen Gang <gang.chen@asianux.com>
To: Thomas Gleixner <tglx@linutronix.de>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: [Suggestion] kernel/irqdesc.c: not checking whether failure occurs for alloc_desc() in early_irq_init().
Date: Tue, 14 May 2013 18:45:00 +0800 [thread overview]
Message-ID: <519215AC.4010109@asianux.com> (raw)
Hello Maintainers:
For early_irq_init(), it may be failure (can return an error code), and
for alloc_desc(), also may return 'NULL' when '-ENOMEM'.
But it seems the authors are sure that early_irq_init() are always
success, is it correct ? (or early_irq_init() will never be used ?)
I think, it is better to also check alloc_desc() return value in
early_irq_init().
Please help check when you have time.
Thanks.
--
Chen Gang
Asianux Corporation
reply other threads:[~2013-05-14 10:45 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=519215AC.4010109@asianux.com \
--to=gang.chen@asianux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.