From: Gary Thomas <gary@mlbassoc.com>
To: Martin Jansa <martin.jansa@gmail.com>
Cc: Yocto Project <yocto@yoctoproject.org>
Subject: Re: IMAGE_FEATURES check broken
Date: Tue, 14 May 2013 05:22:32 -0600 [thread overview]
Message-ID: <51921E78.4090708@mlbassoc.com> (raw)
In-Reply-To: <20130514105619.GG3187@jama>
On 2013-05-14 04:56, Martin Jansa wrote:
> On Tue, May 14, 2013 at 04:45:02AM -0600, Gary Thomas wrote:
>> This commit breaks systems where IMAGE_FEATURES includes "package-management":
>>
>> commit d63c8a1597c9bd0a838cb59ca461ac432b630a90
>> Author: Paul Eggleton <paul.eggleton@linux.intel.com>
>> Date: Thu May 9 17:24:25 2013 +0100
>>
>> classes/image: show an error on invalid IMAGE_FEATURES
>>
>> A quick look at that class shows that package-management is being left
>> out of the "validitems". This patch fixes it:
>>
>> diff --git a/meta/classes/image.bbclass b/meta/classes/image.bbclass
>> index 2b42e12..4f07708 100644
>> --- a/meta/classes/image.bbclass
>> +++ b/meta/classes/image.bbclass
>> @@ -19,7 +19,7 @@ INHIBIT_DEFAULT_DEPS = "1"
>> # IMAGE_FEATURES may contain any available package group
>> IMAGE_FEATURES ?= ""
>> IMAGE_FEATURES[type] = "list"
>> -IMAGE_FEATURES[validitems] += "debug-tweaks read-only-rootfs"
>> +IMAGE_FEATURES[validitems] += "debug-tweaks read-only-rootfs package-management"
>>
>> # rootfs bootstrap install
>> ROOTFS_BOOTSTRAP_INSTALL = "${@base_contains("IMAGE_FEATURES", "package-management", "", "${ROOTFS_PKGMANAGE_BOOTSTR
>>
>> Am I missing something else, or was this just overlooked?
>
> The same patch is already on oe-core ML where it belongs:
> http://lists.linuxtogo.org/pipermail/openembedded-core/2013-May/039541.html
Thanks (I missed that one because it happened late Sunday over here)
Note: I sent my email to this list because of the comment in the commit
which referred directly to a Yocto bug. ... I have a hard time figuring
out where Yocto ends and OE-core begins ...
--
------------------------------------------------------------
Gary Thomas | Consulting for the
MLB Associates | Embedded world
------------------------------------------------------------
prev parent reply other threads:[~2013-05-14 11:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-14 10:45 IMAGE_FEATURES check broken Gary Thomas
2013-05-14 10:48 ` Paul Eggleton
2013-05-14 12:55 ` Paul Eggleton
2013-05-14 10:56 ` Martin Jansa
2013-05-14 11:22 ` Gary Thomas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51921E78.4090708@mlbassoc.com \
--to=gary@mlbassoc.com \
--cc=martin.jansa@gmail.com \
--cc=yocto@yoctoproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.