From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:49546) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UcDVp-0002ds-Tm for qemu-devel@nongnu.org; Tue, 14 May 2013 07:35:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UcDVo-0005Tw-KK for qemu-devel@nongnu.org; Tue, 14 May 2013 07:35:21 -0400 Received: from mx1.redhat.com ([209.132.183.28]:53190) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UcDVo-0005Tk-CP for qemu-devel@nongnu.org; Tue, 14 May 2013 07:35:20 -0400 Message-ID: <51922170.8070808@redhat.com> Date: Tue, 14 May 2013 13:35:12 +0200 From: Gerd Hoffmann MIME-Version: 1.0 References: <1366867752-11578-1-git-send-email-lilei@linux.vnet.ibm.com> <1366867752-11578-3-git-send-email-lilei@linux.vnet.ibm.com> In-Reply-To: <1366867752-11578-3-git-send-email-lilei@linux.vnet.ibm.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 2/4] vnc: Support for LED state extension List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Lei Li Cc: lagarcia@br.ibm.com, aliguori@us.ibm.com, Laszlo Ersek , qemu-devel@nongnu.org On 04/25/13 07:29, Lei Li wrote: > + /* Sending the current led state message to the client */ > + if (ledstate != current_led_state(vs)) { > + vnc_led_state_change(vs); > + } This check never becomes true as the vnc modifier/led state just got updated to match ledstate ... cheers, Gerd