From: Martyn Welch <martyn.welch@ge.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Wei Yongjun <weiyj.lk@gmail.com>,
gmate.amit@gmail.com, devel@driverdev.osuosl.org,
manohar.vanga@gmail.com, gregkh@linuxfoundation.org,
linux-kernel@vger.kernel.org, yamanetoshi@gmail.com,
yongjun_wei@trendmicro.com.cn, joe@perches.com
Subject: Re: [PATCH] staging: vme: fix error return code in vme_user_probe()
Date: Tue, 14 May 2013 14:56:17 +0100 [thread overview]
Message-ID: <51924281.2060509@ge.com> (raw)
In-Reply-To: <20130513085132.GI1360@mwanda>
On 13/05/13 09:51, Dan Carpenter wrote:
> On Mon, May 13, 2013 at 09:16:00AM +0100, Martyn Welch wrote:
>> On 13/05/13 07:05, Wei Yongjun wrote:
>>> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>>>
>>> Fix to return -ENOMEM in the resource alloc error handling
>>> case instead of 0, as done elsewhere in this function.
>>>
>>
>> Hi Wei,
>>
>> Thanks for your patch. As this is resource allocation rather than memory
>> allocation that is failing, would -EAGAIN not make more sense than -ENOMEM?
>>
>
> ENOMEM is better. EAGAIN is for when trylock() fails etc. In other
> words we are not allowed to block and someone is using the lock we
> need.
>
ENOMEM just doesn't seem to describe the error very well. This error will be
triggered if no free VME windows are available for the driver to use - there
are typically 8 master and 8 slave windows provided in hardware.
How about EBUSY (Device or resource busy)?
> It feels like we discuss error codes a lot on LKML and they should
> be documented under Documententation/. The closest thing is
> Documentation/i2c/fault-codes.
>
I'd been looking at the errno man page since I was under the impression that
these values would typically find their way back to user space.
Martyn
--
Martyn Welch (Lead Software Engineer) | Registered in England and Wales
GE Intelligent Platforms | (3828642) at 100 Barbirolli Square
T +44(0)1327322748 | Manchester, M2 3AB
E martyn.welch@ge.com | VAT:GB 927559189
next prev parent reply other threads:[~2013-05-14 13:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-13 6:05 [PATCH] staging: vme: fix error return code in vme_user_probe() Wei Yongjun
2013-05-13 8:16 ` Martyn Welch
2013-05-13 8:51 ` Dan Carpenter
2013-05-14 13:56 ` Martyn Welch [this message]
2013-05-14 14:19 ` Dan Carpenter
2013-05-15 7:56 ` Martyn Welch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51924281.2060509@ge.com \
--to=martyn.welch@ge.com \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gmate.amit@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=manohar.vanga@gmail.com \
--cc=weiyj.lk@gmail.com \
--cc=yamanetoshi@gmail.com \
--cc=yongjun_wei@trendmicro.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.