From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1UcG0v-00023c-09 for mharc-qemu-trivial@gnu.org; Tue, 14 May 2013 10:15:37 -0400 Received: from eggs.gnu.org ([208.118.235.92]:54043) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UcG0q-0001wT-Jd for qemu-trivial@nongnu.org; Tue, 14 May 2013 10:15:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UcG0l-0003k0-Jy for qemu-trivial@nongnu.org; Tue, 14 May 2013 10:15:32 -0400 Received: from isrv.corpit.ru ([86.62.121.231]:60912) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UcG0e-0003iZ-Oe; Tue, 14 May 2013 10:15:21 -0400 Received: from [192.168.88.2] (mjt.vpn.tls.msk.ru [192.168.177.99]) by isrv.corpit.ru (Postfix) with ESMTP id BBCF9409CB; Tue, 14 May 2013 18:15:17 +0400 (MSK) Message-ID: <519246F4.4040803@msgid.tls.msk.ru> Date: Tue, 14 May 2013 18:15:16 +0400 From: Michael Tokarev Organization: Telecom Service, JSC User-Agent: Mozilla/5.0 (X11; Linux i686 on x86_64; rv:17.0) Gecko/17.0 Icedove/17.0 MIME-Version: 1.0 To: Peter Maydell References: <1368530312-16080-1-git-send-email-mjt@msgid.tls.msk.ru> In-Reply-To: X-Enigmail-Version: 1.6a1pre OpenPGP: id=804465C5 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 86.62.121.231 Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH (trivial)] remove some double-includes X-BeenThere: qemu-trivial@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 May 2013 14:15:34 -0000 14.05.2013 15:30, Peter Maydell wrote: > On 14 May 2013 12:18, Michael Tokarev wrote: >> Some source files #include the same header more than >> once for no good reason. Remove second #includes in >> such cases. >> >> diff --git a/translate-all.c b/translate-all.c >> index da93608..a18bf55 100644 >> --- a/translate-all.c >> +++ b/translate-all.c >> @@ -52,21 +52,20 @@ >> #include >> #endif >> #endif >> #else >> #include "exec/address-spaces.h" >> #endif >> #include "qemu/timer.h" >> >> #include "exec/cputlb.h" >> #include "translate-all.h" >> -#include "qemu/timer.h" > > There's already been a patch on the list for this one: > http://patchwork.ozlabs.org/patch/240540/ > Yes I know Peter, and actually this is the patch which prompte me to look for other places. The person in question does not reply (so far), so I thought maybe cleaning up more duplicates is a good idea, or else the patch will just stuck. /mjt From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:53987) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UcG0j-0001q2-V3 for qemu-devel@nongnu.org; Tue, 14 May 2013 10:15:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UcG0f-0003iq-3h for qemu-devel@nongnu.org; Tue, 14 May 2013 10:15:25 -0400 Message-ID: <519246F4.4040803@msgid.tls.msk.ru> Date: Tue, 14 May 2013 18:15:16 +0400 From: Michael Tokarev MIME-Version: 1.0 References: <1368530312-16080-1-git-send-email-mjt@msgid.tls.msk.ru> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH (trivial)] remove some double-includes List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org 14.05.2013 15:30, Peter Maydell wrote: > On 14 May 2013 12:18, Michael Tokarev wrote: >> Some source files #include the same header more than >> once for no good reason. Remove second #includes in >> such cases. >> >> diff --git a/translate-all.c b/translate-all.c >> index da93608..a18bf55 100644 >> --- a/translate-all.c >> +++ b/translate-all.c >> @@ -52,21 +52,20 @@ >> #include >> #endif >> #endif >> #else >> #include "exec/address-spaces.h" >> #endif >> #include "qemu/timer.h" >> >> #include "exec/cputlb.h" >> #include "translate-all.h" >> -#include "qemu/timer.h" > > There's already been a patch on the list for this one: > http://patchwork.ozlabs.org/patch/240540/ > Yes I know Peter, and actually this is the patch which prompte me to look for other places. The person in question does not reply (so far), so I thought maybe cleaning up more duplicates is a good idea, or else the patch will just stuck. /mjt