All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Blake <eblake@redhat.com>
To: Kevin Wolf <kwolf@redhat.com>
Cc: qemu-devel@nongnu.org, stefanha@redhat.com
Subject: Re: [Qemu-devel] [PATCH v2] blockdev: Rename BlockdevAction -> TransactionAction
Date: Tue, 14 May 2013 09:43:42 -0600	[thread overview]
Message-ID: <51925BAE.9040900@redhat.com> (raw)
In-Reply-To: <1368532227-20248-1-git-send-email-kwolf@redhat.com>

[-- Attachment #1: Type: text/plain, Size: 757 bytes --]

On 05/14/2013 05:50 AM, Kevin Wolf wrote:
> There's no reason to restrict transactions to operations related to
> block devices, so rename the type now before schema introspection stops
> us from doing so.
> 
> Also change the schema documentation of 'transaction' to not refer to
> block devices or snapshots any more.

Thanks for fixing that in the respin.  If it helps:

Reviewed-by: Eric Blake <eblake@redhat.com>

> 
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> ---
>  blockdev.c       | 22 +++++++++++-----------
>  qapi-schema.json | 21 ++++++++++-----------
>  2 files changed, 21 insertions(+), 22 deletions(-)
> 

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 621 bytes --]

      parent reply	other threads:[~2013-05-14 15:43 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-14 11:50 [Qemu-devel] [PATCH v2] blockdev: Rename BlockdevAction -> TransactionAction Kevin Wolf
2013-05-14 15:15 ` Stefan Hajnoczi
2013-05-14 15:43 ` Eric Blake [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51925BAE.9040900@redhat.com \
    --to=eblake@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.