All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bo Shen <voice.shen@atmel.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] mmc: fix env in mmc with redundant compile error
Date: Wed, 15 May 2013 09:14:11 +0800	[thread overview]
Message-ID: <5192E163.2030308@atmel.com> (raw)
In-Reply-To: <3692590.gjG8BKSFM4@kerker>

Hi Michael,

On 5/15/2013 02:16, Michael Heimpold wrote:
> Am Montag, 13. Mai 2013, 14:14:46 schrieben Sie:
>> The commit d196bd8 (env_mmc: add support for redundant environment)
>> introduce the following compile error when enable reduandant
>> environment support with MMC
>> ---8<---
>> env_mmc.c:149: error: 'env_t' has no member named 'flags'
>> env_mmc.c:248: error: 'env_t' has no member named 'flags'
>> env_mmc.c:248: error: 'env_t' has no member named 'flags'
>> env_mmc.c:250: error: 'env_t' has no member named 'flags'
>> env_mmc.c:250: error: 'env_t' has no member named 'flags'
>> env_mmc.c:252: error: 'env_t' has no member named 'flags'
>> env_mmc.c:252: error: 'env_t' has no member named 'flags'
>> env_mmc.c:254: error: 'env_t' has no member named 'flags'
>> env_mmc.c:254: error: 'env_t' has no member named 'flags'
>> env_mmc.c:267: error: 'env_t' has no member named 'flags'
>> make[1]: *** [env_mmc.o] Error 1
>> --->8---
>>
>> Add this patch to fix it
>>
>> Signed-off-by: Bo Shen <voice.shen@atmel.com>
>> ---
>>   include/environment.h |    6 ++++++
>>   1 file changed, 6 insertions(+)
>>
>> diff --git a/include/environment.h b/include/environment.h
>> index 4c6a37b..460ccb4 100644
>> --- a/include/environment.h
>> +++ b/include/environment.h
>> @@ -75,6 +75,12 @@
>>   # endif
>>   #endif	/* CONFIG_ENV_IS_IN_FLASH */
>>
>> +#if defined(CONFIG_ENV_IS_IN_MMC)
>> +# ifdef CONFIG_ENV_OFFSET_REDUND
>> +#  define CONFIG_SYS_REDUNDAND_ENVIRONMENT
>> +# endif
>> +#endif
>> +
>>   #if defined(CONFIG_ENV_IS_IN_NAND)
>>   # if defined(CONFIG_ENV_OFFSET_OOB)
>>   #  ifdef CONFIG_ENV_OFFSET_REDUND
>>
>
> s/reduandant/redundant/

Thanks for figure out this, I will correct it in next version.

> Reviewed-by: Michael Heimpold <mhei@heimpold.de>

In next version, I will add your Reviewed-by tag.

Best Regards,
Bo Shen

      reply	other threads:[~2013-05-15  1:14 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-13  6:14 [U-Boot] [PATCH] mmc: fix env in mmc with redundant compile error Bo Shen
2013-05-14 18:16 ` Michael Heimpold
2013-05-15  1:14   ` Bo Shen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5192E163.2030308@atmel.com \
    --to=voice.shen@atmel.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.