From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:49904)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lilei@linux.vnet.ibm.com>) id 1UcUqR-0005kt-Q6
	for qemu-devel@nongnu.org; Wed, 15 May 2013 02:05:51 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <lilei@linux.vnet.ibm.com>) id 1UcUqN-0005vk-Mg
	for qemu-devel@nongnu.org; Wed, 15 May 2013 02:05:47 -0400
Received: from e28smtp05.in.ibm.com ([122.248.162.5]:58610)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lilei@linux.vnet.ibm.com>) id 1UcUqM-0005vX-Nb
	for qemu-devel@nongnu.org; Wed, 15 May 2013 02:05:43 -0400
Received: from /spool/local
	by e28smtp05.in.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use
	Only! Violators will be prosecuted
	for <qemu-devel@nongnu.org> from <lilei@linux.vnet.ibm.com>;
	Wed, 15 May 2013 11:31:35 +0530
Received: from d28relay05.in.ibm.com (d28relay05.in.ibm.com [9.184.220.62])
	by d28dlp02.in.ibm.com (Postfix) with ESMTP id B63753940058
	for <qemu-devel@nongnu.org>; Wed, 15 May 2013 11:35:36 +0530 (IST)
Received: from d28av03.in.ibm.com (d28av03.in.ibm.com [9.184.220.65])
	by d28relay05.in.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id
	r4F65Ubi57213164
	for <qemu-devel@nongnu.org>; Wed, 15 May 2013 11:35:30 +0530
Received: from d28av03.in.ibm.com (loopback [127.0.0.1])
	by d28av03.in.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id
	r4F65Y7W010471
	for <qemu-devel@nongnu.org>; Wed, 15 May 2013 16:05:34 +1000
Message-ID: <5193259F.9020803@linux.vnet.ibm.com>
Date: Wed, 15 May 2013 14:05:19 +0800
From: Lei Li <lilei@linux.vnet.ibm.com>
MIME-Version: 1.0
References: <1366867752-11578-1-git-send-email-lilei@linux.vnet.ibm.com>
	<1366867752-11578-3-git-send-email-lilei@linux.vnet.ibm.com>
	<51922170.8070808@redhat.com>
In-Reply-To: <51922170.8070808@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 2/4] vnc: Support for LED state extension
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: lagarcia@br.ibm.com, aliguori@us.ibm.com, Laszlo Ersek <lersek@redhat.com>, qemu-devel@nongnu.org

On 05/14/2013 07:35 PM, Gerd Hoffmann wrote:
> On 04/25/13 07:29, Lei Li wrote:
>> +    /* Sending the current led state message to the client */
>> +    if (ledstate != current_led_state(vs)) {
>> +        vnc_led_state_change(vs);
>> +    }
> This check never becomes true as the vnc modifier/led state just got
> updated to match ledstate ...

Oh... then how about get rid of this check, let vnc_led_state_change send
the current led state message directly?

>
> cheers,
>    Gerd
>


-- 
Lei