From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:39242) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UcW6h-0006fo-U4 for qemu-devel@nongnu.org; Wed, 15 May 2013 03:26:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UcW6f-0004Ne-6O for qemu-devel@nongnu.org; Wed, 15 May 2013 03:26:39 -0400 Received: from e28smtp02.in.ibm.com ([122.248.162.2]:56283) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UcW6e-0004NH-G9 for qemu-devel@nongnu.org; Wed, 15 May 2013 03:26:37 -0400 Received: from /spool/local by e28smtp02.in.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 15 May 2013 12:50:08 +0530 Received: from d28relay02.in.ibm.com (d28relay02.in.ibm.com [9.184.220.59]) by d28dlp01.in.ibm.com (Postfix) with ESMTP id 72B4BE004C for ; Wed, 15 May 2013 12:58:54 +0530 (IST) Received: from d28av03.in.ibm.com (d28av03.in.ibm.com [9.184.220.65]) by d28relay02.in.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r4F7QJ1x4784506 for ; Wed, 15 May 2013 12:56:20 +0530 Received: from d28av03.in.ibm.com (loopback [127.0.0.1]) by d28av03.in.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id r4F7QOuF008149 for ; Wed, 15 May 2013 17:26:24 +1000 Message-ID: <5193388F.1020609@linux.vnet.ibm.com> Date: Wed, 15 May 2013 15:26:07 +0800 From: Lei Li MIME-Version: 1.0 References: <1368589953-22455-1-git-send-email-lilei@linux.vnet.ibm.com> <51931F75.8040107@redhat.com> In-Reply-To: <51931F75.8040107@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] chardev: Get filename for new qapi backend List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org On 05/15/2013 01:39 PM, Gerd Hoffmann wrote: > On 05/15/13 05:52, Lei Li wrote: >> This patch add the filename when the new qapi backend init from opts. >> >> Commit 2c5f488293c7d0cd095635c74157c2526e2c4947 add support for >> qapi-based chardev initialization, but miss the filename of the >> char device as below: >> >> (qemu) info chardev >> parallel0: filename=(null) >> serial0: filename=(null) >> compat_monitor0: filename=(null) >> @@ -3276,6 +3276,7 @@ CharDriverState *qemu_chr_new_from_opts(QemuOpts *opts, >> ChardevReturn *ret = NULL; >> const char *id = qemu_opts_id(opts); >> const char *bid = NULL; >> + char *filename = g_strdup(qemu_opt_get(opts, "backend")); >> >> if (qemu_opt_get_bool(opts, "mux", 0)) { >> bid = g_strdup_printf("%s-base", id); >> @@ -3308,6 +3309,7 @@ CharDriverState *qemu_chr_new_from_opts(QemuOpts *opts, >> } >> >> chr = qemu_chr_find(id); >> + chr->filename = filename; > That should happen in qmp_chardev_add(), so filename is set consistently > for every chardev no matter how it gets created. Yeah, I was hesitant to add it here for that it does not looks very logical... But I am not sure about the best place for it.. > Take care to not overwrite filename, some functions > (qmp_chardev_open_socket for example) do set chr->filename already. Yes, for the char device pipe, pty, socket, they set chr->filename in their own open functions. But I think the overwrite will not happen because it will not get "backend" by qemu_opt_get() for these chardevs. > > Maybe it's better to put that into the individual qmp_chardev_open_* > functions anyway. OK, I'll have a try and see if everyone like it, I don't have better idea. > > cheers, > Gerd > > > -- Lei