All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: liguang <lig.fnst@cn.fujitsu.com>
Cc: Anthony Liguori <aliguori@us.ibm.com>,
	Bruce Rogers <brogers@suse.com>,
	Gerd Hoffmann <kraxel@redhat.com>,
	qemu-devel@nongnu.org, mst@redhat.com
Subject: Re: [Qemu-devel] [PATCH 2/2] pc: reject do pc_acpi_init if acpi_enabled is false
Date: Wed, 15 May 2013 10:38:45 +0200	[thread overview]
Message-ID: <51934995.4010000@redhat.com> (raw)
In-Reply-To: <1368590499-11707-2-git-send-email-lig.fnst@cn.fujitsu.com>

Il 15/05/2013 06:01, liguang ha scritto:
> Signed-off-by: liguang <lig.fnst@cn.fujitsu.com>

--verbose, please.

What problem does this patch fix?

Paolo

> ---
>  hw/i386/pc.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/hw/i386/pc.c b/hw/i386/pc.c
> index 197d218..77025a8 100644
> --- a/hw/i386/pc.c
> +++ b/hw/i386/pc.c
> @@ -982,7 +982,7 @@ void pc_acpi_init(const char *default_dsdt)
>  {
>      char *filename;
>  
> -    if (acpi_tables != NULL) {
> +    if (acpi_tables != NULL || !acpi_enabled) {
>          /* manually set via -acpitable, leave it alone */
>          return;
>      }
> 

  reply	other threads:[~2013-05-15  8:39 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-15  4:01 [Qemu-devel] [PATCH 1/2] vl: boolize acpi_enabled liguang
2013-05-15  4:01 ` [Qemu-devel] [PATCH 2/2] pc: reject do pc_acpi_init if acpi_enabled is false liguang
2013-05-15  8:38   ` Paolo Bonzini [this message]
2013-05-15  8:54     ` li guang
2013-05-15 13:44       ` Laszlo Ersek
2013-05-16  0:14         ` li guang
2013-05-16 10:22           ` Laszlo Ersek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51934995.4010000@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=aliguori@us.ibm.com \
    --cc=brogers@suse.com \
    --cc=kraxel@redhat.com \
    --cc=lig.fnst@cn.fujitsu.com \
    --cc=mst@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.