From: Santosh Shilimkar <santosh.shilimkar@ti.com>
To: "Vincent Stehlé" <vincent.stehle@laposte.net>
Cc: "Tony Lindgren" <tony@atomide.com>,
linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org,
"Vincent Stehlé" <v-stehle@ti.com>
Subject: Re: [PATCH] ARM: OMAP5: select SCU
Date: Wed, 15 May 2013 18:06:57 +0530 [thread overview]
Message-ID: <51938169.4060109@ti.com> (raw)
In-Reply-To: <1368550638-2046-1-git-send-email-vincent.stehle@laposte.net>
On Tuesday 14 May 2013 10:27 PM, Vincent Stehlé wrote:
> From: Vincent Stehlé <v-stehle@ti.com>
>
> OMAP5 needs SCU in SMP.
>
> This fixes the following link errors:
>
> arch/arm/mach-omap2/built-in.o: In function `scu_gp_set':
> arch/arm/mach-omap2/sleep44xx.S:132: undefined reference to `scu_power_mode'
> arch/arm/mach-omap2/built-in.o: In function `scu_gp_clear':
> arch/arm/mach-omap2/sleep44xx.S:229: undefined reference to `scu_power_mode'
> arch/arm/mach-omap2/built-in.o: In function `omap4_smp_prepare_cpus':
> arch/arm/mach-omap2/omap-smp.c:211: undefined reference to `scu_enable'
> arch/arm/mach-omap2/built-in.o: In function `omap4_smp_init_cpus':
> arch/arm/mach-omap2/omap-smp.c:185: undefined reference to `scu_get_core_count'
>
> Signed-off-by: Vincent Stehlé <v-stehle@ti.com>
> ---
OMAP5 doesn't need the SCU. So Nak for the patch. I haven't noticed
this earlier. Do you know which commit broke this ?
Regards,
Santosh
next prev parent reply other threads:[~2013-05-15 12:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-14 16:57 [PATCH] ARM: OMAP5: select SCU Vincent Stehlé
2013-05-15 12:36 ` Santosh Shilimkar [this message]
2013-05-16 13:10 ` Vincent Stehlé
2013-05-16 14:29 ` Vincent Stehlé
2013-05-17 7:16 ` Shilimkar, Santosh
2013-05-16 16:00 ` [RFC PATCH v2] ARM: OMAP4+: protect SCU code compilation Vincent Stehlé
2013-05-16 16:00 ` Vincent Stehlé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51938169.4060109@ti.com \
--to=santosh.shilimkar@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=tony@atomide.com \
--cc=v-stehle@ti.com \
--cc=vincent.stehle@laposte.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.