All of lore.kernel.org
 help / color / mirror / Atom feed
From: Zhang Yanfei <zhangyanfei.yes@gmail.com>
To: "H. Peter Anvin" <hpa@zytor.com>,
	mingo@redhat.com, tglx@linutronix.de,
	Andrew Morton <akpm@linux-foundation.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: [PATCH] x86, setup: Correct comment in reserve_crashkernel
Date: Wed, 15 May 2013 23:34:22 +0800	[thread overview]
Message-ID: <5193AAFE.2010406@gmail.com> (raw)

From: Zhang Yanfei <zhangyanfei@cn.fujitsu.com>

One comment in reserve_crashkernel is out of date and incorrect.
So fix it.

Signed-off-by: Zhang Yanfei <zhangyanfei@cn.fujitsu.com>
---
 arch/x86/kernel/setup.c |    7 ++++++-
 1 files changed, 6 insertions(+), 1 deletions(-)

diff --git a/arch/x86/kernel/setup.c b/arch/x86/kernel/setup.c
index 56f7fcf..eba0d78 100644
--- a/arch/x86/kernel/setup.c
+++ b/arch/x86/kernel/setup.c
@@ -590,7 +590,12 @@ static void __init reserve_crashkernel(void)
 	/* 0 means: find the address automatically */
 	if (crash_base <= 0) {
 		/*
-		 *  kexec want bzImage is below CRASH_KERNEL_ADDR_MAX
+		 *  For x86_64, when crashkernel=X,high is not passed, kexec
+		 *  wants bzImage is below CRASH_KERNEL_ADDR_LOW_MAX.
+		 *  For x86_32, crashkernel=X,high is not supported by defining
+		 *  CRASH_KERNEL_ADDR_HIGH_MAX and CRASH_KERNEL_ADDR_LOW_MAX
+		 *  with the same limit and kexec always wants bzImage is below
+		 *  this limit due to mapping restrictions.
 		 */
 		crash_base = memblock_find_in_range(alignment,
 					high ? CRASH_KERNEL_ADDR_HIGH_MAX :
-- 
1.7.1

                 reply	other threads:[~2013-05-15 15:34 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5193AAFE.2010406@gmail.com \
    --to=zhangyanfei.yes@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.