From: Tom Rini <trini@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] mmc and fat bug fixes
Date: Wed, 15 May 2013 19:07:06 -0400 [thread overview]
Message-ID: <5194151A.8020601@ti.com> (raw)
In-Reply-To: <1808571307.844971.1368632224152.JavaMail.root@advansee.com>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 05/15/2013 11:37 AM, Beno?t Th?baudeau wrote:
> Hi Ruud,
>
> On Wednesday, May 15, 2013 4:23:51 PM, Ruud Commandeur wrote:
>> This patch fixes a number of mmc and fat-related bugs:
[snip]
>> @@ -901,7 +902,8 @@ }
>>
>> curclust = get_fatent_value(mydata, dir_curclust); - if
>> ((curclust >= 0xffffff8) || (curclust >= 0xfff8)) { + if
>> (((curclust >= 0xffffff8) && (mydata->fatsize == 32)) || +
>> ((curclust >= 0xfff8) && (mydata->fatsize == 16))) {
>> empty_dentptr = dentptr; return NULL; }
>>
>
> These 2 hunks are correct, but please remove the parentheses
> around the "==" expressions: They make the code less readable. And
> add another tab to indent the 2nd line of the if-s so that it is
> more indented than the if block contents.
With regards to style, checkpatch.pl wins (so please use it on your
patch, git format-patch -n1 ; ./tools/checkpatch.pl
./0001-what-git-said-it-called-it) and it should be:
if ((one big test) ||
(second test)) {
<tab>... code ...
}
- --
Tom
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/
iQIcBAEBAgAGBQJRlBUZAAoJENk4IS6UOR1WGLUQAK1zwb+enZWBQ0j1HXeQUiMx
mnErR6WKBqg7Tt5ya72abdE5tGmulS6QThrT1uXP98u/qUfiEBEDHb5MRy8cRdL8
LKvplOFVkl9iZXbHqD9/u5FUT9A2t/L0nMEYBG8akCIaxqOPLSgB5U7NbkJohrGE
2jhFN1cLXKFkRujstEjefDw720sIBesWXeLLKIzHG8YujxdRkYGr5bi3iHMNSG90
nOIkf7+umd72QqFVs7Sq2xCmNLzntsx1m76DkX0fJ0ReAlkoBfWEvkTKjmr+ANPz
ksualH7u2PWz53h021iVA+b2SZtWhHj5GgqhShFKoqKyyjUyktn/4J9qan0rDp88
6+p3H5bpYfBhOWGzb9lkX+krc1F7ViJO4CABWNZO/ux4Sg+cdpKsFwyVJfSzh1wd
jViZg0oq+qMT5u+XEFY1QAivP0rcL3wiVQ+YUXOfAqjx1zik3EMl0f6FO/71AGnm
SlYGm39dhTyU5kEruCJBVWk97eEh8ETVLIZ/giaEi6HVsw/uv8yElLq4KtdxC7P0
pnNmR+wGnzifJiCYFDgIRKvpFaUCgqfxb6ac717PL7XDb5d3TMfWdfgR4FKMDK7b
GWTiEnA3hLUWUGCdwYflH1JqzJxzXRQBP3Gc7QOqKtHSEcQ1Hc3tlm4kAKvAfF0k
ys0ayHOizfdTTjE2JlPS
=QJxA
-----END PGP SIGNATURE-----
next prev parent reply other threads:[~2013-05-15 23:07 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-15 14:23 [U-Boot] [PATCH] mmc and fat bug fixes Ruud Commandeur
2013-05-15 15:37 ` Benoît Thébaudeau
2013-05-15 23:07 ` Tom Rini [this message]
2013-05-15 22:14 ` Andy Fleming
2013-05-16 9:26 ` Ruud Commandeur
2013-05-17 20:17 ` Andy Fleming
2013-05-16 5:55 ` Wolfgang Denk
2013-05-16 8:04 ` Ruud Commandeur
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5194151A.8020601@ti.com \
--to=trini@ti.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.