From: DAN LI <li.dan@cn.fujitsu.com>
To: LTP list <ltp-list@lists.sourceforge.net>
Subject: [LTP] [PATCH] prot_hsymlinks.c: remove the unnecessary calling of cleanup
Date: Thu, 16 May 2013 14:08:37 +0800 [thread overview]
Message-ID: <519477E5.4030807@cn.fujitsu.com> (raw)
Should not call cleanup here since nothing was setted by setup.
Signed-off-by: DAN LI <li.dan@cn.fujitsu.com>
---
testcases/kernel/security/prot_hsymlinks/prot_hsymlinks.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/testcases/kernel/security/prot_hsymlinks/prot_hsymlinks.c
b/testcases/kernel/security/prot_hsymlinks/prot_hsymlinks.c
index 1eec0f9..82bc770 100644
--- a/testcases/kernel/security/prot_hsymlinks/prot_hsymlinks.c
+++ b/testcases/kernel/security/prot_hsymlinks/prot_hsymlinks.c
@@ -196,10 +196,9 @@ static void setup(int argc, char *argv[])
tst_require_root(NULL);
- if (tst_kvercmp(3, 7, 0) < 0) {
- tst_brkm(TCONF, cleanup,
+ if (tst_kvercmp(3, 7, 0) < 0)
+ tst_brkm(TCONF, NULL,
"Test must be run with kernel 3.7 or newer");
- }
/* initialize user names */
strcpy(users[ROOT].name, "root");
--
1.7.11.rc0
------------------------------------------------------------------------------
AlienVault Unified Security Management (USM) platform delivers complete
security visibility with the essential security capabilities. Easily and
efficiently configure, manage, and operate all of your security controls
from a single console and one unified framework. Download a free trial.
http://p.sf.net/sfu/alienvault_d2d
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
next reply other threads:[~2013-05-16 6:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-16 6:08 DAN LI [this message]
2013-05-21 2:58 ` [LTP] [PATCH] prot_hsymlinks.c: remove the unnecessary calling of cleanup DAN LI
2013-05-21 3:45 ` Wanlong Gao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=519477E5.4030807@cn.fujitsu.com \
--to=li.dan@cn.fujitsu.com \
--cc=ltp-list@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.