From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from [222.73.24.84] (helo=song.cn.fujitsu.com) by merlin.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1UcsdN-0001z7-8c for kexec@lists.infradead.org; Thu, 16 May 2013 07:29:54 +0000 Message-ID: <51948885.5040408@cn.fujitsu.com> Date: Thu, 16 May 2013 15:19:33 +0800 From: Zhang Yanfei MIME-Version: 1.0 Subject: Re: [PATCH v6 7/8] vmcore: calculate vmcore file size from buffer size and total size of vmcore objects References: <20130515090507.28109.28956.stgit@localhost6.localdomain6> <20130515090620.28109.68803.stgit@localhost6.localdomain6> In-Reply-To: <20130515090620.28109.68803.stgit@localhost6.localdomain6> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "kexec" Errors-To: kexec-bounces+dwmw2=twosheds.infradead.org@lists.infradead.org To: HATAYAMA Daisuke Cc: riel@redhat.com, hughd@google.com, jingbai.ma@hp.com, kexec@lists.infradead.org, linux-kernel@vger.kernel.org, lisa.mitchell@hp.com, linux-mm@kvack.org, kumagai-atsushi@mxc.nes.nec.co.jp, ebiederm@xmission.com, kosaki.motohiro@jp.fujitsu.com, akpm@linux-foundation.org, walken@google.com, cpw@sgi.com, vgoyal@redhat.com 5LqOIDIwMTPlubQwNeaciDE15pelIDE3OjA2LCBIQVRBWUFNQSBEYWlzdWtlIOWGmemBkzoKPiBU aGUgcHJldmlvdXMgcGF0Y2hlcyBuZXdseSBhZGRlZCBob2xlcyBiZWZvcmUgZWFjaCBjaHVuayBv ZiBtZW1vcnkgYW5kCj4gdGhlIGhvbGVzIG5lZWQgdG8gYmUgY291bnQgaW4gdm1jb3JlIGZpbGUg c2l6ZS4gVGhlcmUgYXJlIHR3byB3YXlzIHRvCj4gY291bnQgZmlsZSBzaXplIGluIHN1Y2ggYSB3 YXk6Cj4gCj4gMSkgc3VwcG9yc2UgbSBhcyBhIHBvaXRuZXIgdG8gdGhlIGxhc3Qgdm1jb3JlIG9i amVjdCBpbiB2bWNvcmVfbGlzdC4KPiAsIHRoZW4gZmlsZSBzaXplIGlzIChtLT5vZmZzZXQgKyBt LT5zaXplKSwgb3IKPiAKPiAyKSBjYWxjdWxhdGUgc3VtIG9mIHNpemUgb2YgYnVmZmVycyBmb3Ig RUxGIGhlYWRlciwgcHJvZ3JhbSBoZWFkZXJzLAo+IEVMRiBub3RlIHNlZ21lbnRzIGFuZCBvYmpl Y3RzIGluIHZtY29yZV9saXN0Lgo+IAo+IEFsdGhvdWdoIDEpIGlzIG1vcmUgZGlyZWN0IGFuZCBz aW1wbGVyIHRoYW4gMiksIDIpIHNlZW1zIGJldHRlciBpbgo+IHRoYXQgaXQgcmVmbGVjdHMgaW50 ZXJuYWwgb2JqZWN0IHN0cnVjdHVyZSBvZiAvcHJvYy92bWNvcmUuIFRodXMsIHRoaXMKPiBwYXRj aCBjaGFuZ2VzIGdldF92bWNvcmVfc2l6ZV9lbGZ7NjQsIDMyfSBzbyB0aGF0IGl0IGNhbGN1bGF0 ZXMgc2l6ZQo+IGluIHRoZSB3YXkgb2YgMikuCj4gCj4gU2lnbmVkLW9mZi1ieTogSEFUQVlBTUEg RGFpc3VrZSA8ZC5oYXRheWFtYUBqcC5mdWppdHN1LmNvbT4KPiBBY2tlZC1ieTogVml2ZWsgR295 YWwgPHZnb3lhbEByZWRoYXQuY29tPgo+IC0tLQoKQWNrZWQtYnk6IFpoYW5nIFlhbmZlaSA8emhh bmd5YW5mZWlAY24uZnVqaXRzdS5jb20+Cgo+IAo+ICBmcy9wcm9jL3ZtY29yZS5jIHwgICA0MCAr KysrKysrKysrKysrKysrKystLS0tLS0tLS0tLS0tLS0tLS0tLS0tCj4gIDEgZmlsZXMgY2hhbmdl ZCwgMTggaW5zZXJ0aW9ucygrKSwgMjIgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2Zz L3Byb2Mvdm1jb3JlLmMgYi9mcy9wcm9jL3ZtY29yZS5jCj4gaW5kZXggNGUxMjFmZGEuLjdmMjA0 MWMgMTAwNjQ0Cj4gLS0tIGEvZnMvcHJvYy92bWNvcmUuYwo+ICsrKyBiL2ZzL3Byb2Mvdm1jb3Jl LmMKPiBAQCAtMjEwLDM2ICsyMTAsMjggQEAgc3RhdGljIHN0cnVjdCB2bWNvcmUqIF9faW5pdCBn ZXRfbmV3X2VsZW1lbnQodm9pZCkKPiAgCXJldHVybiBremFsbG9jKHNpemVvZihzdHJ1Y3Qgdm1j b3JlKSwgR0ZQX0tFUk5FTCk7Cj4gIH0KPiAgCj4gLXN0YXRpYyB1NjQgX19pbml0IGdldF92bWNv cmVfc2l6ZV9lbGY2NChjaGFyICplbGZwdHIsIHNpemVfdCBlbGZzeikKPiArc3RhdGljIHU2NCBf X2luaXQgZ2V0X3ZtY29yZV9zaXplX2VsZjY0KHNpemVfdCBlbGZzeiwgc2l6ZV90IGVsZm5vdGVz ZWdzeiwKPiArCQkJCQlzdHJ1Y3QgbGlzdF9oZWFkICp2Y19saXN0KQo+ICB7Cj4gLQlpbnQgaTsK PiAgCXU2NCBzaXplOwo+IC0JRWxmNjRfRWhkciAqZWhkcl9wdHI7Cj4gLQlFbGY2NF9QaGRyICpw aGRyX3B0cjsKPiArCXN0cnVjdCB2bWNvcmUgKm07Cj4gIAo+IC0JZWhkcl9wdHIgPSAoRWxmNjRf RWhkciAqKWVsZnB0cjsKPiAtCXBoZHJfcHRyID0gKEVsZjY0X1BoZHIqKShlbGZwdHIgKyBzaXpl b2YoRWxmNjRfRWhkcikpOwo+IC0Jc2l6ZSA9IGVsZnN6Owo+IC0JZm9yIChpID0gMDsgaSA8IGVo ZHJfcHRyLT5lX3BobnVtOyBpKyspIHsKPiAtCQlzaXplICs9IHBoZHJfcHRyLT5wX21lbXN6Owo+ IC0JCXBoZHJfcHRyKys7Cj4gKwlzaXplID0gZWxmc3ogKyBlbGZub3Rlc2Vnc3o7Cj4gKwlsaXN0 X2Zvcl9lYWNoX2VudHJ5KG0sIHZjX2xpc3QsIGxpc3QpIHsKPiArCQlzaXplICs9IG0tPnNpemU7 Cj4gIAl9Cj4gIAlyZXR1cm4gc2l6ZTsKPiAgfQo+ICAKPiAtc3RhdGljIHU2NCBfX2luaXQgZ2V0 X3ZtY29yZV9zaXplX2VsZjMyKGNoYXIgKmVsZnB0ciwgc2l6ZV90IGVsZnN6KQo+ICtzdGF0aWMg dTY0IF9faW5pdCBnZXRfdm1jb3JlX3NpemVfZWxmMzIoc2l6ZV90IGVsZnN6LCBzaXplX3QgZWxm bm90ZXNlZ3N6LAo+ICsJCQkJCXN0cnVjdCBsaXN0X2hlYWQgKnZjX2xpc3QpCj4gIHsKPiAtCWlu dCBpOwo+ICAJdTY0IHNpemU7Cj4gLQlFbGYzMl9FaGRyICplaGRyX3B0cjsKPiAtCUVsZjMyX1Bo ZHIgKnBoZHJfcHRyOwo+ICsJc3RydWN0IHZtY29yZSAqbTsKPiAgCj4gLQllaGRyX3B0ciA9IChF bGYzMl9FaGRyICopZWxmcHRyOwo+IC0JcGhkcl9wdHIgPSAoRWxmMzJfUGhkciopKGVsZnB0ciAr IHNpemVvZihFbGYzMl9FaGRyKSk7Cj4gLQlzaXplID0gZWxmc3o7Cj4gLQlmb3IgKGkgPSAwOyBp IDwgZWhkcl9wdHItPmVfcGhudW07IGkrKykgewo+IC0JCXNpemUgKz0gcGhkcl9wdHItPnBfbWVt c3o7Cj4gLQkJcGhkcl9wdHIrKzsKPiArCXNpemUgPSBlbGZzeiArIGVsZm5vdGVzZWdzejsKPiAr CWxpc3RfZm9yX2VhY2hfZW50cnkobSwgdmNfbGlzdCwgbGlzdCkgewo+ICsJCXNpemUgKz0gbS0+ c2l6ZTsKPiAgCX0KPiAgCXJldHVybiBzaXplOwo+ICB9Cj4gQEAgLTc5NSwxNCArNzg3LDE4IEBA IHN0YXRpYyBpbnQgX19pbml0IHBhcnNlX2NyYXNoX2VsZl9oZWFkZXJzKHZvaWQpCj4gIAkJCXJl dHVybiByYzsKPiAgCj4gIAkJLyogRGV0ZXJtaW5lIHZtY29yZSBzaXplLiAqLwo+IC0JCXZtY29y ZV9zaXplID0gZ2V0X3ZtY29yZV9zaXplX2VsZjY0KGVsZmNvcmVidWYsIGVsZmNvcmVidWZfc3op Owo+ICsJCXZtY29yZV9zaXplID0gZ2V0X3ZtY29yZV9zaXplX2VsZjY0KGVsZmNvcmVidWZfc3os Cj4gKwkJCQkJCSAgICBlbGZub3Rlc19zeiwKPiArCQkJCQkJICAgICZ2bWNvcmVfbGlzdCk7Cj4g IAl9IGVsc2UgaWYgKGVfaWRlbnRbRUlfQ0xBU1NdID09IEVMRkNMQVNTMzIpIHsKPiAgCQlyYyA9 IHBhcnNlX2NyYXNoX2VsZjMyX2hlYWRlcnMoKTsKPiAgCQlpZiAocmMpCj4gIAkJCXJldHVybiBy YzsKPiAgCj4gIAkJLyogRGV0ZXJtaW5lIHZtY29yZSBzaXplLiAqLwo+IC0JCXZtY29yZV9zaXpl ID0gZ2V0X3ZtY29yZV9zaXplX2VsZjMyKGVsZmNvcmVidWYsIGVsZmNvcmVidWZfc3opOwo+ICsJ CXZtY29yZV9zaXplID0gZ2V0X3ZtY29yZV9zaXplX2VsZjMyKGVsZmNvcmVidWZfc3osCj4gKwkJ CQkJCSAgICBlbGZub3Rlc19zeiwKPiArCQkJCQkJICAgICZ2bWNvcmVfbGlzdCk7Cj4gIAl9IGVs c2Ugewo+ICAJCXByX3dhcm4oIldhcm5pbmc6IENvcmUgaW1hZ2UgZWxmIGhlYWRlciBpcyBub3Qg c2FuZVxuIik7Cj4gIAkJcmV0dXJuIC1FSU5WQUw7Cj4gCj4gCgoKX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX18Ka2V4ZWMgbWFpbGluZyBsaXN0CmtleGVjQGxp c3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0 aW5mby9rZXhlYwo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx128.postini.com [74.125.245.128]) by kanga.kvack.org (Postfix) with SMTP id B1ACD6B0033 for ; Thu, 16 May 2013 03:29:29 -0400 (EDT) Message-ID: <51948885.5040408@cn.fujitsu.com> Date: Thu, 16 May 2013 15:19:33 +0800 From: Zhang Yanfei MIME-Version: 1.0 Subject: Re: [PATCH v6 7/8] vmcore: calculate vmcore file size from buffer size and total size of vmcore objects References: <20130515090507.28109.28956.stgit@localhost6.localdomain6> <20130515090620.28109.68803.stgit@localhost6.localdomain6> In-Reply-To: <20130515090620.28109.68803.stgit@localhost6.localdomain6> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Sender: owner-linux-mm@kvack.org List-ID: To: HATAYAMA Daisuke Cc: vgoyal@redhat.com, ebiederm@xmission.com, akpm@linux-foundation.org, cpw@sgi.com, kumagai-atsushi@mxc.nes.nec.co.jp, lisa.mitchell@hp.com, kexec@lists.infradead.org, linux-kernel@vger.kernel.org, jingbai.ma@hp.com, linux-mm@kvack.org, riel@redhat.com, walken@google.com, hughd@google.com, kosaki.motohiro@jp.fujitsu.com =E4=BA=8E 2013=E5=B9=B405=E6=9C=8815=E6=97=A5 17:06, HATAYAMA Daisuke =E5= =86=99=E9=81=93: > The previous patches newly added holes before each chunk of memory and > the holes need to be count in vmcore file size. There are two ways to > count file size in such a way: >=20 > 1) supporse m as a poitner to the last vmcore object in vmcore=5Flist. > , then file size is (m->offset + m->size), or >=20 > 2) calculate sum of size of buffers for ELF header, program headers, > ELF note segments and objects in vmcore=5Flist. >=20 > Although 1) is more direct and simpler than 2), 2) seems better in > that it reflects internal object structure of /proc/vmcore. Thus, this > patch changes get=5Fvmcore=5Fsize=5Felf{64, 32} so that it calculates size > in the way of 2). >=20 > Signed-off-by: HATAYAMA Daisuke > Acked-by: Vivek Goyal > --- Acked-by: Zhang Yanfei >=20 > fs/proc/vmcore.c | 40 ++++++++++++++++++---------------------- > 1 files changed, 18 insertions(+), 22 deletions(-) >=20 > diff --git a/fs/proc/vmcore.c b/fs/proc/vmcore.c > index 4e121fda..7f2041c 100644 > --- a/fs/proc/vmcore.c > +++ b/fs/proc/vmcore.c > @@ -210,36 +210,28 @@ static struct vmcore* =5F=5Finit get=5Fnew=5Felemen= t(void) > return kzalloc(sizeof(struct vmcore), GFP=5FKERNEL); > } > =20 > -static u64 =5F=5Finit get=5Fvmcore=5Fsize=5Felf64(char *elfptr, size=5Ft= elfsz) > +static u64 =5F=5Finit get=5Fvmcore=5Fsize=5Felf64(size=5Ft elfsz, size= =5Ft elfnotesegsz, > + struct list=5Fhead *vc=5Flist) > { > - int i; > u64 size; > - Elf64=5FEhdr *ehdr=5Fptr; > - Elf64=5FPhdr *phdr=5Fptr; > + struct vmcore *m; > =20 > - ehdr=5Fptr =3D (Elf64=5FEhdr *)elfptr; > - phdr=5Fptr =3D (Elf64=5FPhdr*)(elfptr + sizeof(Elf64=5FEhdr)); > - size =3D elfsz; > - for (i =3D 0; i < ehdr=5Fptr->e=5Fphnum; i++) { > - size +=3D phdr=5Fptr->p=5Fmemsz; > - phdr=5Fptr++; > + size =3D elfsz + elfnotesegsz; > + list=5Ffor=5Feach=5Fentry(m, vc=5Flist, list) { > + size +=3D m->size; > } > return size; > } > =20 > -static u64 =5F=5Finit get=5Fvmcore=5Fsize=5Felf32(char *elfptr, size=5Ft= elfsz) > +static u64 =5F=5Finit get=5Fvmcore=5Fsize=5Felf32(size=5Ft elfsz, size= =5Ft elfnotesegsz, > + struct list=5Fhead *vc=5Flist) > { > - int i; > u64 size; > - Elf32=5FEhdr *ehdr=5Fptr; > - Elf32=5FPhdr *phdr=5Fptr; > + struct vmcore *m; > =20 > - ehdr=5Fptr =3D (Elf32=5FEhdr *)elfptr; > - phdr=5Fptr =3D (Elf32=5FPhdr*)(elfptr + sizeof(Elf32=5FEhdr)); > - size =3D elfsz; > - for (i =3D 0; i < ehdr=5Fptr->e=5Fphnum; i++) { > - size +=3D phdr=5Fptr->p=5Fmemsz; > - phdr=5Fptr++; > + size =3D elfsz + elfnotesegsz; > + list=5Ffor=5Feach=5Fentry(m, vc=5Flist, list) { > + size +=3D m->size; > } > return size; > } > @@ -795,14 +787,18 @@ static int =5F=5Finit parse=5Fcrash=5Felf=5Fheaders= (void) > return rc; > =20 > /* Determine vmcore size. */ > - vmcore=5Fsize =3D get=5Fvmcore=5Fsize=5Felf64(elfcorebuf, elfcorebuf= =5Fsz); > + vmcore=5Fsize =3D get=5Fvmcore=5Fsize=5Felf64(elfcorebuf=5Fsz, > + elfnotes=5Fsz, > + &vmcore=5Flist); > } else if (e=5Fident[EI=5FCLASS] =3D=3D ELFCLASS32) { > rc =3D parse=5Fcrash=5Felf32=5Fheaders(); > if (rc) > return rc; > =20 > /* Determine vmcore size. */ > - vmcore=5Fsize =3D get=5Fvmcore=5Fsize=5Felf32(elfcorebuf, elfcorebuf= =5Fsz); > + vmcore=5Fsize =3D get=5Fvmcore=5Fsize=5Felf32(elfcorebuf=5Fsz, > + elfnotes=5Fsz, > + &vmcore=5Flist); > } else { > pr=5Fwarn("Warning: Core image elf header is not sane\n"); > return -EINVAL; >=20 >=20 = -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756273Ab3EPIA5 (ORCPT ); Thu, 16 May 2013 04:00:57 -0400 Received: from cn.fujitsu.com ([222.73.24.84]:27733 "EHLO song.cn.fujitsu.com" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1754122Ab3EPIA4 convert rfc822-to-8bit (ORCPT ); Thu, 16 May 2013 04:00:56 -0400 X-IronPort-AV: E=Sophos;i="4.87,683,1363104000"; d="scan'208";a="7284471" Message-ID: <51948885.5040408@cn.fujitsu.com> Date: Thu, 16 May 2013 15:19:33 +0800 From: Zhang Yanfei User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0.8) Gecko/20121012 Thunderbird/10.0.8 MIME-Version: 1.0 To: HATAYAMA Daisuke CC: vgoyal@redhat.com, ebiederm@xmission.com, akpm@linux-foundation.org, cpw@sgi.com, kumagai-atsushi@mxc.nes.nec.co.jp, lisa.mitchell@hp.com, kexec@lists.infradead.org, linux-kernel@vger.kernel.org, jingbai.ma@hp.com, linux-mm@kvack.org, riel@redhat.com, walken@google.com, hughd@google.com, kosaki.motohiro@jp.fujitsu.com Subject: Re: [PATCH v6 7/8] vmcore: calculate vmcore file size from buffer size and total size of vmcore objects References: <20130515090507.28109.28956.stgit@localhost6.localdomain6> <20130515090620.28109.68803.stgit@localhost6.localdomain6> In-Reply-To: <20130515090620.28109.68803.stgit@localhost6.localdomain6> X-MIMETrack: Itemize by SMTP Server on mailserver/fnst(Release 8.5.3|September 15, 2011) at 2013/05/16 15:20:44, Serialize by Router on mailserver/fnst(Release 8.5.3|September 15, 2011) at 2013/05/16 15:21:01 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 于 2013年05月15日 17:06, HATAYAMA Daisuke 写道: > The previous patches newly added holes before each chunk of memory and > the holes need to be count in vmcore file size. There are two ways to > count file size in such a way: > > 1) supporse m as a poitner to the last vmcore object in vmcore_list. > , then file size is (m->offset + m->size), or > > 2) calculate sum of size of buffers for ELF header, program headers, > ELF note segments and objects in vmcore_list. > > Although 1) is more direct and simpler than 2), 2) seems better in > that it reflects internal object structure of /proc/vmcore. Thus, this > patch changes get_vmcore_size_elf{64, 32} so that it calculates size > in the way of 2). > > Signed-off-by: HATAYAMA Daisuke > Acked-by: Vivek Goyal > --- Acked-by: Zhang Yanfei > > fs/proc/vmcore.c | 40 ++++++++++++++++++---------------------- > 1 files changed, 18 insertions(+), 22 deletions(-) > > diff --git a/fs/proc/vmcore.c b/fs/proc/vmcore.c > index 4e121fda..7f2041c 100644 > --- a/fs/proc/vmcore.c > +++ b/fs/proc/vmcore.c > @@ -210,36 +210,28 @@ static struct vmcore* __init get_new_element(void) > return kzalloc(sizeof(struct vmcore), GFP_KERNEL); > } > > -static u64 __init get_vmcore_size_elf64(char *elfptr, size_t elfsz) > +static u64 __init get_vmcore_size_elf64(size_t elfsz, size_t elfnotesegsz, > + struct list_head *vc_list) > { > - int i; > u64 size; > - Elf64_Ehdr *ehdr_ptr; > - Elf64_Phdr *phdr_ptr; > + struct vmcore *m; > > - ehdr_ptr = (Elf64_Ehdr *)elfptr; > - phdr_ptr = (Elf64_Phdr*)(elfptr + sizeof(Elf64_Ehdr)); > - size = elfsz; > - for (i = 0; i < ehdr_ptr->e_phnum; i++) { > - size += phdr_ptr->p_memsz; > - phdr_ptr++; > + size = elfsz + elfnotesegsz; > + list_for_each_entry(m, vc_list, list) { > + size += m->size; > } > return size; > } > > -static u64 __init get_vmcore_size_elf32(char *elfptr, size_t elfsz) > +static u64 __init get_vmcore_size_elf32(size_t elfsz, size_t elfnotesegsz, > + struct list_head *vc_list) > { > - int i; > u64 size; > - Elf32_Ehdr *ehdr_ptr; > - Elf32_Phdr *phdr_ptr; > + struct vmcore *m; > > - ehdr_ptr = (Elf32_Ehdr *)elfptr; > - phdr_ptr = (Elf32_Phdr*)(elfptr + sizeof(Elf32_Ehdr)); > - size = elfsz; > - for (i = 0; i < ehdr_ptr->e_phnum; i++) { > - size += phdr_ptr->p_memsz; > - phdr_ptr++; > + size = elfsz + elfnotesegsz; > + list_for_each_entry(m, vc_list, list) { > + size += m->size; > } > return size; > } > @@ -795,14 +787,18 @@ static int __init parse_crash_elf_headers(void) > return rc; > > /* Determine vmcore size. */ > - vmcore_size = get_vmcore_size_elf64(elfcorebuf, elfcorebuf_sz); > + vmcore_size = get_vmcore_size_elf64(elfcorebuf_sz, > + elfnotes_sz, > + &vmcore_list); > } else if (e_ident[EI_CLASS] == ELFCLASS32) { > rc = parse_crash_elf32_headers(); > if (rc) > return rc; > > /* Determine vmcore size. */ > - vmcore_size = get_vmcore_size_elf32(elfcorebuf, elfcorebuf_sz); > + vmcore_size = get_vmcore_size_elf32(elfcorebuf_sz, > + elfnotes_sz, > + &vmcore_list); > } else { > pr_warn("Warning: Core image elf header is not sane\n"); > return -EINVAL; > >