From mboxrd@z Thu Jan  1 00:00:00 1970
From: Michal Kazior <michal.kazior@tieto.com>
Date: Thu, 16 May 2013 10:25:41 +0200
Subject: [ath9k-devel] [PATCH 1/2] ath10k: Convert ath10k_dbg uses
In-Reply-To: <1368687816.2194.49.camel@joe-AO722>
References: <20130515143356.4492.43033.stgit@localhost6.localdomain6>
	<1368639816.2194.9.camel@joe-AO722>	<8761yknn7i.fsf@kamboji.qca.qualcomm.com>
	<1368687816.2194.49.camel@joe-AO722>
Message-ID: <51949805.7010509@tieto.com>
List-Id: <ath9k-devel.lists.ath9k.org>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: ath9k-devel@lists.ath9k.org

On 16/05/13 09:03, Joe Perches wrote:
> Neaten and shorten the uses of ath10k_dbg and ath10k_dbg_dump.
>
> Add macros to hold the "ATH10K_DBG_" mask portion of the functions.

I'm not really fond of this idea. It's harder to locate symbols when 
doing macro name concatenation. You can't jump to, e.g. WMI symbol 
definition because it doesn't exist (ATH10K_DBG_WMI is what you actually 
want). Although you don't look for this symbol often so I guess it's 
okay-ish.


-- Pozdrawiam / Best regards, Michal Kazior.