From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:43047) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Uczov-0005j0-UC for qemu-devel@nongnu.org; Thu, 16 May 2013 11:10:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Uczoq-0003Zj-7b for qemu-devel@nongnu.org; Thu, 16 May 2013 11:10:17 -0400 Received: from mail-gg0-x234.google.com ([2607:f8b0:4002:c02::234]:57486) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Uczoq-0003Ze-2P for qemu-devel@nongnu.org; Thu, 16 May 2013 11:10:12 -0400 Received: by mail-gg0-f180.google.com with SMTP id q4so612817ggn.39 for ; Thu, 16 May 2013 08:10:11 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <5194F6C7.3020106@redhat.com> Date: Thu, 16 May 2013 17:09:59 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1368678651-3561-1-git-send-email-akong@redhat.com> <51948969.5050604@linux.vnet.ibm.com> <20130516073521.GE3785@t430s.nay.redhat.com> <5194A2DF.9010608@linux.vnet.ibm.com> <20130516203703.GB3045@t430s.nay.redhat.com> In-Reply-To: <20130516203703.GB3045@t430s.nay.redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH] ps2: add support of auto-repeat List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Amos Kong Cc: aliguori@us.ibm.com, Lei Li , qemu-devel@nongnu.org, lcapitulino@redhat.com, kraxel@redhat.com, lersek@redhat.com Il 16/05/2013 22:37, Amos Kong ha scritto: > On Thu, May 16, 2013 at 05:11:59PM +0800, Lei Li wrote: >> On 05/16/2013 03:35 PM, Amos Kong wrote: >>> On Thu, May 16, 2013 at 03:23:21PM +0800, Lei Li wrote: >>>> On 05/16/2013 12:30 PM, Amos Kong wrote: >>>>> Guest driver sets repeat rate and delay time by KBD_CMD_SET_RATE, >>>>> but ps2 backend doesn't process it and no auto-repeat implementation. >>>>> This patch adds support of auto-repeat feature. >>>>> >>>>> Guest ps2 driver sets autorepeat to fastest possible in reset, >>>>> period: 250ms, delay: 33ms >>>>> >>>>> Tested by 'sendkey' monitor command. >>>>> >>>>> referenced: http://www.computer-engineering.org/ps2keyboard/ >>>>> >>>>> Signed-off-by: Amos Kong >>> >>>>> /* >>>>> keycode is expressed as follow: >>>>> bit 7 - 0 key pressed, 1 = key released >>>>> @@ -167,7 +186,17 @@ static void ps2_put_keycode(void *opaque, int keycode) >>>>> keycode = ps2_raw_keycode_set3[keycode & 0x7f]; >>>>> } >>>>> } >>>>> + >>>>> + /* only auto-repeat press event */ >>>>> + auto_repeat = ~keycode & 0x80; >>> Hi Lei, >>> >>>> Does this check allow to distinguish the difference between auto-repeat and >>>> actual repeated entry by the user? >>> Actual repeat by user: >>> press event >>> release event >>> press event >>> release event >>> press event >>> release event >>> >>> Auto-repeat example: >>> press event >>> press event >>> press event >>> release event > > Hi Lei, > >> On what platform? > > > Fedora 18 @ thinkpad t430s > > [root@t430s amos]# showkey (hold 'a') > akeycode 30 press > aaaaaaaaaaakeycode 30 press > keycode 30 press > keycode 30 press > keycode 30 press > keycode 30 press > keycode 30 press > keycode 30 press > keycode 30 press > keycode 30 press > keycode 30 press > keycode 30 press > keycode 30 press > keycode 30 press > aakeycode 30 press > keycode 30 press > keycode 30 release <----(one release event in the end) > > > Qemu VM (rhel6, using vnc/ SDL) can get same result. > >> AFAIK, the Auto-repeat event is like below on some GTK-based >> ||||||||||||environments,|||||||||||| >> >> keydown >> keypress >> keyup >> keydown >> keypress >> keyup||||||||||||| >> ... >> as reference link: >> >> https://developer.mozilla.org/zh-CN/docs/DOM/KeyboardEvent > > ===== Auto-repeat handling (it's also mentioned in mozilla page) > > When a key is pressed and held down, it begins to auto-repeat. This > results in a sequence of events similar to the following being > dispatched: > > keydown > keypress > keydown > keypress > <> > keyup <----(only one up event in the end) > >> And on Xwindows: >> >> keypress >> keyrelease >> keypress >> keyrelease >> ... >> as reference link: >> >> http://www.ypass.net/blog/2009/06/detecting-xlibs-keyboard-auto-repeat-functionality-and-how-to-fix-it/ > > """Just what we’d expect, a bunch of KeyPress Events and one KeyRelease > event. But that’s not how it works in X.""" ... In XWindows, you get a KeyRelease for every KeyPress Event. In X, it looks something like this: PRPRPRPRPRPRPRPR Can you test your patch with all of VNC, SDL and GTK+? Paolo