From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:48734)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1Ud06z-000647-3p
	for qemu-devel@nongnu.org; Thu, 16 May 2013 11:29:02 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1Ud06u-0000oA-9j
	for qemu-devel@nongnu.org; Thu, 16 May 2013 11:28:56 -0400
Received: from mx1.redhat.com ([209.132.183.28]:43175)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1Ud06u-0000o5-18
	for qemu-devel@nongnu.org; Thu, 16 May 2013 11:28:52 -0400
Message-ID: <5194F945.8040601@redhat.com>
Date: Thu, 16 May 2013 17:20:37 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1368678651-3561-1-git-send-email-akong@redhat.com>
	<51948969.5050604@linux.vnet.ibm.com>
	<20130516073521.GE3785@t430s.nay.redhat.com>
	<5194A2DF.9010608@linux.vnet.ibm.com>
	<20130516203703.GB3045@t430s.nay.redhat.com>
	<5194F6C7.3020106@redhat.com>
	<CAFEAcA9UQ14L5DMbjiUoQYwMHC2jfDJbkC1_+dZqfDz3q4npFQ@mail.gmail.com>
In-Reply-To: <CAFEAcA9UQ14L5DMbjiUoQYwMHC2jfDJbkC1_+dZqfDz3q4npFQ@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] ps2: add support of auto-repeat
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: aliguori@us.ibm.com, Lei Li <lilei@linux.vnet.ibm.com>, qemu-devel@nongnu.org, lcapitulino@redhat.com, kraxel@redhat.com, Amos Kong <akong@redhat.com>, lersek@redhat.com

Il 16/05/2013 17:17, Peter Maydell ha scritto:
> On 16 May 2013 16:09, Paolo Bonzini <pbonzini@redhat.com> wrote:
>> ...  In XWindows, you get a KeyRelease for every KeyPress Event. In X,
>> it looks something like this:
>>
>> PRPRPRPRPRPRPRPR
> 
> Shouldn't we be abstracting this platform difference
> out in the ui layer, rather than having to deal with it
> in the ps2 device model? That is, we should define what
> our key-repeat model is for the QEMU keyboard-event-handler
> API, and then make sure all our UI frontends (gtk, sdl,
> cocoa, etc) do what we require...

Yes, I am asking Amos to check which of our frontends comply.

It needs to be checked in the host, because Linux guests emulate
autorepeat anyway.  Or you can test with FreeDOS.

Paolo