Re: [Qemu-devel] [PATCH] scsi: reset cdrom tray statuses on scsi_disk_reset

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1042 bytes --]

On 05/16/2013 09:34 AM, Pavel Hrdina wrote:
> Tray statuses should be also reseted. Some guests may lock the tray

s/reseted/reset/

> and after reset before any kernel is loaded the tray should be unlocked.
> 
> Also if you reset the real computer the tray is closed. We should
> do the same in qemu.

Is that OS-independent hardware behavior, or is tray closing on boot
merely a side effect observed on bare metal but caused by installed
software (BIOS or OS code)?  At any rate, being consistent with IDE
doesn't hurt.

> 
> This fix is already commited for IDE CD.

s/commited/committed/

> Check the commit a7f3d65b65b8c86a5ff0c0abcfefb45e2ec6fe4c.
> 
> Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
> ---
>  hw/scsi/scsi-disk.c | 3 +++
>  1 file changed, 3 insertions(+)

assuming the maintainer can touch up the commit message, feel free to add:

Reviewed-by: Eric Blake <eblake@redhat.com>

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 621 bytes --]