From mboxrd@z Thu Jan 1 00:00:00 1970 From: Xiao Guangrong Subject: Re: [PATCH v5 3/8] KVM: MMU: fast invalidate all pages Date: Fri, 17 May 2013 02:40:57 +0800 Message-ID: <51952839.1090902@linux.vnet.ibm.com> References: <1368706673-8530-1-git-send-email-xiaoguangrong@linux.vnet.ibm.com> <1368706673-8530-4-git-send-email-xiaoguangrong@linux.vnet.ibm.com> <20130516161816.GG14597@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: avi.kivity@gmail.com, mtosatti@redhat.com, pbonzini@redhat.com, linux-kernel@vger.kernel.org, kvm@vger.kernel.org To: Gleb Natapov Return-path: Received: from e23smtp03.au.ibm.com ([202.81.31.145]:46131 "EHLO e23smtp03.au.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751524Ab3EPSlG (ORCPT ); Thu, 16 May 2013 14:41:06 -0400 Received: from /spool/local by e23smtp03.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 17 May 2013 04:32:44 +1000 In-Reply-To: <20130516161816.GG14597@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 05/17/2013 12:18 AM, Gleb Natapov wrote: >> + >> +/* >> + * Fast invalidate all shadow pages belong to @slot. >> + * >> + * @slot != NULL means the invalidation is caused the memslot specified >> + * by @slot is being deleted, in this case, we should ensure that rmap >> + * and lpage-info of the @slot can not be used after calling the function. >> + * >> + * @slot == NULL means the invalidation due to other reasons, we need >> + * not care rmap and lpage-info since they are still valid after calling >> + * the function. >> + */ >> +void kvm_mmu_invalidate_memslot_pages(struct kvm *kvm, >> + struct kvm_memory_slot *slot) > > Why pass "slot" here? If we want the function to sometimes wait for purge > and sometimes not the more straightforward way is to have a "bool wait" > parameter instead. > That's my fault, i forgot to update it. Will use 'bool zap_invalid_pages' instead.