From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Rob Herring <robherring2@gmail.com>
Cc: Simon Horman <horms@verge.net.au>,
linux-sh@vger.kernel.org, devicetree-discuss@lists.ozlabs.org,
linux-kernel@vger.kernel.org, rob.herring@calxeda.com,
vladimir.barinov@cogentembedded.com
Subject: Re: [PATCH] <linux/of_platform.h>: fix compilation warnings with DT disabled
Date: Thu, 16 May 2013 20:58:23 +0000 [thread overview]
Message-ID: <5195486F.1040603@cogentembedded.com> (raw)
In-Reply-To: <5130B506.5020908@gmail.com>
Hello.
On 03/01/2013 05:02 PM, Rob Herring wrote:
>>>>>> Fix the following compilation warnings (in Simon Horman's
>>>>>> renesas.git repo):
>>>>>> In file included from arch/arm/mach-shmobile/setup-r8a7779.c:24:0:
>>>>>> include/linux/of_platform.h:107:13: warning: ‘struct of_device_id’
>>>>>> declared
>>>>>> inside parameter list [enabled by default]
>>>>>> include/linux/of_platform.h:107:13: warning: its scope is only this
>>>>>> definition
>>>>>> or declaration, which is probably not what you want [enabled by
>>>>>> default]
>>>>>> include/linux/of_platform.h:107:13: warning: ‘struct device_node’
>>>>>> declared
>>>>>> inside parameter list [enabled by default]
>>>>>> <linux/of_platform.h> only #include's headers with definitions of
>>>>>> the above
>>>>>> mentioned structures if CONFIG_OF_DEVICE=y but uses them even if
>>>>>> not. One
>>>>>> solution is to move some #include's out of #ifdef CONFIG_OF_DEVICE
>>>>>> and use
>>>>>> incomplete declarations for the rest of the structures where the
>>>>>> #ifdef move
>>>>>> doesn't help...
>>>>>> Reported-by: Vladimir Barinov <vladimir.barinov@cogentembedded.com>
>>>>>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
>>>>> Reviewed-by: Simon Horman <horms+renesas@verge.net.au>
>>>>> Grant, could you consider taking this patch?
>>>> Yes, I can, but I don't seem to have the original patch. Can you send it
>>>> again.
>>> Nevermind. Found it. I'll apply it.
>> Will you drop 'struct device_node' declaration then or should I
>> resend? In fact, I think I should better resend it with the changelog
>> somewhat edited.
> No, I plan to leave it as is and not rely on device.h by chance
> declaring device_node.
I hoped to see this fix in 3.10-rc1. Is there any hope to see it in
3.10-rc's?
The code it fixes the warnings in is already in Linus tree.
>
>>> Rob
WBR, Sergei
WARNING: multiple messages have this Message-ID (diff)
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Rob Herring <robherring2@gmail.com>
Cc: Simon Horman <horms@verge.net.au>,
linux-sh@vger.kernel.org, devicetree-discuss@lists.ozlabs.org,
linux-kernel@vger.kernel.org, rob.herring@calxeda.com,
vladimir.barinov@cogentembedded.com
Subject: Re: [PATCH] <linux/of_platform.h>: fix compilation warnings with DT disabled
Date: Fri, 17 May 2013 00:58:23 +0400 [thread overview]
Message-ID: <5195486F.1040603@cogentembedded.com> (raw)
In-Reply-To: <5130B506.5020908@gmail.com>
Hello.
On 03/01/2013 05:02 PM, Rob Herring wrote:
>>>>>> Fix the following compilation warnings (in Simon Horman's
>>>>>> renesas.git repo):
>>>>>> In file included from arch/arm/mach-shmobile/setup-r8a7779.c:24:0:
>>>>>> include/linux/of_platform.h:107:13: warning: ‘struct of_device_id’
>>>>>> declared
>>>>>> inside parameter list [enabled by default]
>>>>>> include/linux/of_platform.h:107:13: warning: its scope is only this
>>>>>> definition
>>>>>> or declaration, which is probably not what you want [enabled by
>>>>>> default]
>>>>>> include/linux/of_platform.h:107:13: warning: ‘struct device_node’
>>>>>> declared
>>>>>> inside parameter list [enabled by default]
>>>>>> <linux/of_platform.h> only #include's headers with definitions of
>>>>>> the above
>>>>>> mentioned structures if CONFIG_OF_DEVICE=y but uses them even if
>>>>>> not. One
>>>>>> solution is to move some #include's out of #ifdef CONFIG_OF_DEVICE
>>>>>> and use
>>>>>> incomplete declarations for the rest of the structures where the
>>>>>> #ifdef move
>>>>>> doesn't help...
>>>>>> Reported-by: Vladimir Barinov <vladimir.barinov@cogentembedded.com>
>>>>>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
>>>>> Reviewed-by: Simon Horman <horms+renesas@verge.net.au>
>>>>> Grant, could you consider taking this patch?
>>>> Yes, I can, but I don't seem to have the original patch. Can you send it
>>>> again.
>>> Nevermind. Found it. I'll apply it.
>> Will you drop 'struct device_node' declaration then or should I
>> resend? In fact, I think I should better resend it with the changelog
>> somewhat edited.
> No, I plan to leave it as is and not rely on device.h by chance
> declaring device_node.
I hoped to see this fix in 3.10-rc1. Is there any hope to see it in
3.10-rc's?
The code it fixes the warnings in is already in Linus tree.
>
>>> Rob
WBR, Sergei
next prev parent reply other threads:[~2013-05-16 20:58 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-18 22:58 [PATCH] <linux/of_platform.h>: fix compilation warnings with DT disabled Sergei Shtylyov
2013-02-18 23:58 ` Sergei Shtylyov
2013-03-01 7:09 ` Simon Horman
2013-03-01 7:09 ` Simon Horman
2013-03-01 13:46 ` Rob Herring
2013-03-01 13:46 ` Rob Herring
2013-03-01 13:48 ` Rob Herring
2013-03-01 13:48 ` Rob Herring
2013-03-01 13:55 ` Sergei Shtylyov
2013-03-01 13:55 ` Sergei Shtylyov
2013-03-01 14:02 ` Rob Herring
2013-03-01 14:02 ` Rob Herring
2013-05-16 20:58 ` Sergei Shtylyov [this message]
2013-05-16 20:58 ` Sergei Shtylyov
2013-05-16 22:44 ` Rob Herring
2013-05-16 22:44 ` Rob Herring
2013-05-17 16:49 ` Grant Likely
2013-05-17 16:49 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5195486F.1040603@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=horms@verge.net.au \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=rob.herring@calxeda.com \
--cc=robherring2@gmail.com \
--cc=vladimir.barinov@cogentembedded.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.