From: Ric Wheeler <rwheeler@redhat.com>
To: Zach Brown <zab@redhat.com>
Cc: Eric Wong <normalperson@yhbt.net>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Trond Myklebust <Trond.Myklebust@netapp.com>,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-btrfs@vger.kernel.org, linux-nfs@vger.kernel.org
Subject: Re: [RFC v0 1/4] vfs: add copy_range syscall and vfs entry point
Date: Thu, 16 May 2013 17:16:44 -0400 [thread overview]
Message-ID: <51954CBC.7070308@redhat.com> (raw)
In-Reply-To: <20130515200307.GD318@lenny.home.zabbo.net>
On 05/15/2013 04:03 PM, Zach Brown wrote:
> On Wed, May 15, 2013 at 07:44:05PM +0000, Eric Wong wrote:
>> Why introduce a new syscall instead of extending sys_splice?
> Personally, I think it's ugly to have different operations use the same
> syscall just because their arguments match.
I agree with Zach - having a system call called "splice" do copy offloads is not
intuitive.
This is a very reasonable name for something that battled its way through
several standards bodies (for NFS and SCSI :)), so we should give it a
reasonable name
thanks!
Ric
>
> But that preference aside, sure, if the consensus is that we'd rather
> use the splice() entry point then I can duck tape the pieces together to
> make it work.
>
>> If the user doesn't need a out offset, then sendfile() should also be
>> able to transparently utilize COPY/CLONE_RANGE, too.
> Perhaps, yeah.
>
> - z
next prev parent reply other threads:[~2013-05-16 21:16 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-14 21:15 [RFC v0 0/4] sys_copy_range() rough draft Zach Brown
2013-05-14 21:15 ` [RFC v0 1/4] vfs: add copy_range syscall and vfs entry point Zach Brown
2013-05-15 19:44 ` Eric Wong
2013-05-15 20:03 ` Zach Brown
2013-05-16 21:16 ` Ric Wheeler [this message]
2013-05-21 19:47 ` Eric Wong
2013-05-21 19:50 ` Zach Brown
2013-05-14 21:15 ` [RFC v0 2/4] x86: add sys_copy_range to syscall tables Zach Brown
2013-05-14 21:15 ` [RFC v0 3/4] btrfs: add .copy_range file operation Zach Brown
2013-05-14 21:15 ` [RFC v0 4/4] nfs, nfsd: rough sys_copy_range and COPY support Zach Brown
2013-05-14 21:15 ` Zach Brown
2013-05-15 20:19 ` J. Bruce Fields
2013-05-15 20:19 ` J. Bruce Fields
2013-05-15 20:21 ` Myklebust, Trond
2013-05-15 20:21 ` Myklebust, Trond
2013-05-15 20:24 ` J. Bruce Fields
2013-05-14 21:42 ` [RFC v0 0/4] sys_copy_range() rough draft Dave Chinner
2013-05-14 21:42 ` Dave Chinner
2013-05-14 22:04 ` Zach Brown
2013-05-15 1:01 ` Dave Chinner
-- strict thread matches above, loose matches on Subject: below --
2013-05-15 17:50 [RFC v0 1/4] vfs: add copy_range syscall and vfs entry point Steve French
2013-05-15 18:54 ` J. Bruce Fields
[not found] ` <20130515185429.GA25994-uC3wQj2KruNg9hUCZPvPmw@public.gmane.org>
2013-05-15 19:39 ` Zach Brown
[not found] ` <CAH2r5ms0P8Hgv1mUpyHA32Er38iiaC1HHC4fhxvz2SBFy6Sucw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-05-15 19:36 ` Zach Brown
[not found] ` <20130515193600.GA318-fypN+1c5dIyjpB87vu3CluTW4wlIGRCZ@public.gmane.org>
2013-05-15 20:08 ` Steve French
2013-05-15 20:16 ` Chris Mason
[not found] ` <20130515201614.24668.83788-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2013-05-15 20:21 ` Steve French
2013-05-15 20:25 ` Chris Mason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51954CBC.7070308@redhat.com \
--to=rwheeler@redhat.com \
--cc=Trond.Myklebust@netapp.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=normalperson@yhbt.net \
--cc=zab@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.