From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Francois Romieu <romieu@fr.zoreil.com>
Cc: "David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, "Hayes Wang" <hayeswang@realtek.com>,
"Stefan Bader" <stefan.bader@canonical.com>,
"Holger Hoffstätte" <holger.hoffstaette@googlemail.com>
Subject: Re: [PATCH] r8169: fix offloaded tx checksum for small packets.
Date: Fri, 17 May 2013 02:59:34 +0400 [thread overview]
Message-ID: <519564D6.8050409@cogentembedded.com> (raw)
In-Reply-To: <20130516223857.GA20140@electric-eye.fr.zoreil.com>
Hello.
On 05/17/2013 02:38 AM, Francois Romieu wrote:
> 8168evl offloaded checksums are wrong since
> e5195c1f31f399289347e043d6abf3ffa80f0005
Please, also specify that commit's summary line in parens.
> pads small packets to
> 60 bytes (without ethernet checksum). Observed UDP checksums are
> typically wrong by the count of added bytes.
>
> It isn't worth compensating. Let's checksum by hand, then pad.
>
> Signed-off-by: Francois Romieu <romieu@fr.zoreil.com>
> Cc: Hayes Wang <hayeswang@realtek.com>
> Tested-by: Holger Hoffstätte <holger.hoffstaette@googlemail.com>
WBR, Sergei
next prev parent reply other threads:[~2013-05-16 22:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-16 22:38 [PATCH] r8169: fix offloaded tx checksum for small packets Francois Romieu
2013-05-16 22:59 ` Sergei Shtylyov [this message]
2013-05-16 23:00 ` Ben Hutchings
2013-05-18 10:10 ` Francois Romieu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=519564D6.8050409@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=davem@davemloft.net \
--cc=hayeswang@realtek.com \
--cc=holger.hoffstaette@googlemail.com \
--cc=netdev@vger.kernel.org \
--cc=romieu@fr.zoreil.com \
--cc=stefan.bader@canonical.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.