From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from fgwmail6.fujitsu.co.jp ([192.51.44.36]) by merlin.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1Ud7sV-0003FK-Gx for kexec@lists.infradead.org; Thu, 16 May 2013 23:46:33 +0000 Received: from m2.gw.fujitsu.co.jp (unknown [10.0.50.72]) by fgwmail6.fujitsu.co.jp (Postfix) with ESMTP id 300D43EE0AE for ; Fri, 17 May 2013 08:46:03 +0900 (JST) Received: from smail (m2 [127.0.0.1]) by outgoing.m2.gw.fujitsu.co.jp (Postfix) with ESMTP id 20DFC45DE4E for ; Fri, 17 May 2013 08:46:03 +0900 (JST) Received: from s2.gw.fujitsu.co.jp (s2.gw.fujitsu.co.jp [10.0.50.92]) by m2.gw.fujitsu.co.jp (Postfix) with ESMTP id 0B5D845DDCF for ; Fri, 17 May 2013 08:46:03 +0900 (JST) Received: from s2.gw.fujitsu.co.jp (localhost.localdomain [127.0.0.1]) by s2.gw.fujitsu.co.jp (Postfix) with ESMTP id EE81C1DB803A for ; Fri, 17 May 2013 08:46:02 +0900 (JST) Received: from m1000.s.css.fujitsu.com (m1000.s.css.fujitsu.com [10.240.81.136]) by s2.gw.fujitsu.co.jp (Postfix) with ESMTP id A60921DB802C for ; Fri, 17 May 2013 08:46:02 +0900 (JST) Message-ID: <51956FA3.6040806@jp.fujitsu.com> Date: Fri, 17 May 2013 08:45:39 +0900 From: HATAYAMA Daisuke MIME-Version: 1.0 Subject: Re: [PATCH v6 4/8] vmalloc: make find_vm_area check in range References: <20130515090507.28109.28956.stgit@localhost6.localdomain6> <20130515090602.28109.90142.stgit@localhost6.localdomain6> In-Reply-To: List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "kexec" Errors-To: kexec-bounces+dwmw2=twosheds.infradead.org@lists.infradead.org To: KOSAKI Motohiro Cc: "riel@redhat.com" , Hugh Dickins , kexec@lists.infradead.org, LKML , lisa.mitchell@hp.com, vgoyal@redhat.com, "linux-mm@kvack.org" , kumagai-atsushi@mxc.nes.nec.co.jp, "Eric W. Biederman" , zhangyanfei@cn.fujitsu.com, Andrew Morton , Michel Lespinasse , cpw@sgi.com, jingbai.ma@hp.com (2013/05/16 6:37), KOSAKI Motohiro wrote: > On Wed, May 15, 2013 at 5:06 AM, HATAYAMA Daisuke > wrote: >> Currently, __find_vmap_area searches for the kernel VM area starting >> at a given address. This patch changes this behavior so that it >> searches for the kernel VM area to which the address belongs. This >> change is needed by remap_vmalloc_range_partial to be introduced in >> later patch that receives any position of kernel VM area as target >> address. >> >> This patch changes the condition (addr > va->va_start) to the >> equivalent (addr >= va->va_end) by taking advantage of the fact that >> each kernel VM area is non-overlapping. >> >> Signed-off-by: HATAYAMA Daisuke >> --- >> >> mm/vmalloc.c | 2 +- >> 1 files changed, 1 insertions(+), 1 deletions(-) >> >> diff --git a/mm/vmalloc.c b/mm/vmalloc.c >> index d365724..3875fa2 100644 >> --- a/mm/vmalloc.c >> +++ b/mm/vmalloc.c >> @@ -292,7 +292,7 @@ static struct vmap_area *__find_vmap_area(unsigned long addr) >> va = rb_entry(n, struct vmap_area, rb_node); >> if (addr < va->va_start) >> n = n->rb_left; >> - else if (addr > va->va_start) >> + else if (addr >= va->va_end) >> n = n->rb_right; > > OK. This is natural definition. Looks good. > > Acked-by: KOSAKI Motohiro Thanks for your reviewing. Could you or other someone review the next 5/8 patch too? It also changes vmalloc and cc people's review is needed. -- Thanks. HATAYAMA, Daisuke _______________________________________________ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx200.postini.com [74.125.245.200]) by kanga.kvack.org (Postfix) with SMTP id 399026B0032 for ; Thu, 16 May 2013 19:46:06 -0400 (EDT) Received: from m4.gw.fujitsu.co.jp (unknown [10.0.50.74]) by fgwmail5.fujitsu.co.jp (Postfix) with ESMTP id 9DD933EE0C5 for ; Fri, 17 May 2013 08:46:03 +0900 (JST) Received: from smail (m4 [127.0.0.1]) by outgoing.m4.gw.fujitsu.co.jp (Postfix) with ESMTP id 1EB9145DE50 for ; Fri, 17 May 2013 08:46:03 +0900 (JST) Received: from s4.gw.fujitsu.co.jp (s4.gw.fujitsu.co.jp [10.0.50.94]) by m4.gw.fujitsu.co.jp (Postfix) with ESMTP id 040BE45DE4D for ; Fri, 17 May 2013 08:46:03 +0900 (JST) Received: from s4.gw.fujitsu.co.jp (localhost.localdomain [127.0.0.1]) by s4.gw.fujitsu.co.jp (Postfix) with ESMTP id EB619E08003 for ; Fri, 17 May 2013 08:46:02 +0900 (JST) Received: from m1000.s.css.fujitsu.com (m1000.s.css.fujitsu.com [10.240.81.136]) by s4.gw.fujitsu.co.jp (Postfix) with ESMTP id A26421DB802F for ; Fri, 17 May 2013 08:46:02 +0900 (JST) Message-ID: <51956FA3.6040806@jp.fujitsu.com> Date: Fri, 17 May 2013 08:45:39 +0900 From: HATAYAMA Daisuke MIME-Version: 1.0 Subject: Re: [PATCH v6 4/8] vmalloc: make find_vm_area check in range References: <20130515090507.28109.28956.stgit@localhost6.localdomain6> <20130515090602.28109.90142.stgit@localhost6.localdomain6> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: KOSAKI Motohiro Cc: "riel@redhat.com" , Hugh Dickins , jingbai.ma@hp.com, kexec@lists.infradead.org, LKML , lisa.mitchell@hp.com, "linux-mm@kvack.org" , kumagai-atsushi@mxc.nes.nec.co.jp, "Eric W. Biederman" , zhangyanfei@cn.fujitsu.com, Andrew Morton , Michel Lespinasse , cpw@sgi.com, vgoyal@redhat.com (2013/05/16 6:37), KOSAKI Motohiro wrote: > On Wed, May 15, 2013 at 5:06 AM, HATAYAMA Daisuke > wrote: >> Currently, __find_vmap_area searches for the kernel VM area starting >> at a given address. This patch changes this behavior so that it >> searches for the kernel VM area to which the address belongs. This >> change is needed by remap_vmalloc_range_partial to be introduced in >> later patch that receives any position of kernel VM area as target >> address. >> >> This patch changes the condition (addr > va->va_start) to the >> equivalent (addr >= va->va_end) by taking advantage of the fact that >> each kernel VM area is non-overlapping. >> >> Signed-off-by: HATAYAMA Daisuke >> --- >> >> mm/vmalloc.c | 2 +- >> 1 files changed, 1 insertions(+), 1 deletions(-) >> >> diff --git a/mm/vmalloc.c b/mm/vmalloc.c >> index d365724..3875fa2 100644 >> --- a/mm/vmalloc.c >> +++ b/mm/vmalloc.c >> @@ -292,7 +292,7 @@ static struct vmap_area *__find_vmap_area(unsigned long addr) >> va = rb_entry(n, struct vmap_area, rb_node); >> if (addr < va->va_start) >> n = n->rb_left; >> - else if (addr > va->va_start) >> + else if (addr >= va->va_end) >> n = n->rb_right; > > OK. This is natural definition. Looks good. > > Acked-by: KOSAKI Motohiro Thanks for your reviewing. Could you or other someone review the next 5/8 patch too? It also changes vmalloc and cc people's review is needed. -- Thanks. HATAYAMA, Daisuke -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755210Ab3EPXqH (ORCPT ); Thu, 16 May 2013 19:46:07 -0400 Received: from fgwmail6.fujitsu.co.jp ([192.51.44.36]:48389 "EHLO fgwmail6.fujitsu.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754551Ab3EPXqG (ORCPT ); Thu, 16 May 2013 19:46:06 -0400 X-SecurityPolicyCheck: OK by SHieldMailChecker v1.8.9 X-SHieldMailCheckerPolicyVersion: FJ-ISEC-20120718-2 Message-ID: <51956FA3.6040806@jp.fujitsu.com> Date: Fri, 17 May 2013 08:45:39 +0900 From: HATAYAMA Daisuke User-Agent: Mozilla/5.0 (Windows NT 5.1; rv:17.0) Gecko/20130509 Thunderbird/17.0.6 MIME-Version: 1.0 To: KOSAKI Motohiro CC: "riel@redhat.com" , Hugh Dickins , jingbai.ma@hp.com, kexec@lists.infradead.org, LKML , lisa.mitchell@hp.com, "linux-mm@kvack.org" , kumagai-atsushi@mxc.nes.nec.co.jp, "Eric W. Biederman" , zhangyanfei@cn.fujitsu.com, Andrew Morton , Michel Lespinasse , cpw@sgi.com, vgoyal@redhat.com Subject: Re: [PATCH v6 4/8] vmalloc: make find_vm_area check in range References: <20130515090507.28109.28956.stgit@localhost6.localdomain6> <20130515090602.28109.90142.stgit@localhost6.localdomain6> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org (2013/05/16 6:37), KOSAKI Motohiro wrote: > On Wed, May 15, 2013 at 5:06 AM, HATAYAMA Daisuke > wrote: >> Currently, __find_vmap_area searches for the kernel VM area starting >> at a given address. This patch changes this behavior so that it >> searches for the kernel VM area to which the address belongs. This >> change is needed by remap_vmalloc_range_partial to be introduced in >> later patch that receives any position of kernel VM area as target >> address. >> >> This patch changes the condition (addr > va->va_start) to the >> equivalent (addr >= va->va_end) by taking advantage of the fact that >> each kernel VM area is non-overlapping. >> >> Signed-off-by: HATAYAMA Daisuke >> --- >> >> mm/vmalloc.c | 2 +- >> 1 files changed, 1 insertions(+), 1 deletions(-) >> >> diff --git a/mm/vmalloc.c b/mm/vmalloc.c >> index d365724..3875fa2 100644 >> --- a/mm/vmalloc.c >> +++ b/mm/vmalloc.c >> @@ -292,7 +292,7 @@ static struct vmap_area *__find_vmap_area(unsigned long addr) >> va = rb_entry(n, struct vmap_area, rb_node); >> if (addr < va->va_start) >> n = n->rb_left; >> - else if (addr > va->va_start) >> + else if (addr >= va->va_end) >> n = n->rb_right; > > OK. This is natural definition. Looks good. > > Acked-by: KOSAKI Motohiro Thanks for your reviewing. Could you or other someone review the next 5/8 patch too? It also changes vmalloc and cc people's review is needed. -- Thanks. HATAYAMA, Daisuke