From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from fgwmail6.fujitsu.co.jp ([192.51.44.36]) by merlin.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1Ud7tc-0003Hq-KI for kexec@lists.infradead.org; Thu, 16 May 2013 23:47:41 +0000 Received: from m4.gw.fujitsu.co.jp (unknown [10.0.50.74]) by fgwmail6.fujitsu.co.jp (Postfix) with ESMTP id 095D23EE0B6 for ; Fri, 17 May 2013 08:47:19 +0900 (JST) Received: from smail (m4 [127.0.0.1]) by outgoing.m4.gw.fujitsu.co.jp (Postfix) with ESMTP id EAB1645DE51 for ; Fri, 17 May 2013 08:47:18 +0900 (JST) Received: from s4.gw.fujitsu.co.jp (s4.gw.fujitsu.co.jp [10.0.50.94]) by m4.gw.fujitsu.co.jp (Postfix) with ESMTP id D298A45DE4F for ; Fri, 17 May 2013 08:47:18 +0900 (JST) Received: from s4.gw.fujitsu.co.jp (localhost.localdomain [127.0.0.1]) by s4.gw.fujitsu.co.jp (Postfix) with ESMTP id C248F1DB803E for ; Fri, 17 May 2013 08:47:18 +0900 (JST) Received: from m1001.s.css.fujitsu.com (m1001.s.css.fujitsu.com [10.240.81.139]) by s4.gw.fujitsu.co.jp (Postfix) with ESMTP id 794751DB8037 for ; Fri, 17 May 2013 08:47:18 +0900 (JST) Message-ID: <51956FF6.3070205@jp.fujitsu.com> Date: Fri, 17 May 2013 08:47:02 +0900 From: HATAYAMA Daisuke MIME-Version: 1.0 Subject: Re: [PATCH v6 6/8] vmcore: allocate ELF note segment in the 2nd kernel vmalloc memory References: <20130515090507.28109.28956.stgit@localhost6.localdomain6> <20130515090614.28109.26492.stgit@localhost6.localdomain6> <20130516203236.GG5904@redhat.com> In-Reply-To: <20130516203236.GG5904@redhat.com> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "kexec" Errors-To: kexec-bounces+dwmw2=twosheds.infradead.org@lists.infradead.org To: Vivek Goyal Cc: riel@redhat.com, hughd@google.com, kexec@lists.infradead.org, linux-kernel@vger.kernel.org, lisa.mitchell@hp.com, linux-mm@kvack.org, kumagai-atsushi@mxc.nes.nec.co.jp, ebiederm@xmission.com, kosaki.motohiro@jp.fujitsu.com, zhangyanfei@cn.fujitsu.com, akpm@linux-foundation.org, walken@google.com, cpw@sgi.com, jingbai.ma@hp.com (2013/05/17 5:32), Vivek Goyal wrote: > On Wed, May 15, 2013 at 06:06:14PM +0900, HATAYAMA Daisuke wrote: > > [..] > >> +static int __init get_note_number_and_size_elf32(const Elf32_Ehdr *ehdr_ptr, >> + int *nr_ptnote, u64 *phdr_sz) >> +{ >> + return process_note_headers_elf32(ehdr_ptr, nr_ptnote, phdr_sz, NULL); >> +} >> + >> +static int __init copy_notes_elf32(const Elf32_Ehdr *ehdr_ptr, char *notes_buf) >> +{ >> + return process_note_headers_elf32(ehdr_ptr, NULL, NULL, notes_buf); >> +} >> + > > Please don't do this. We need to create two separate functions doing > two different operations and not just create wrapper around a function > which does two things. > > I know both functions will have similar for loops for going through > the elf notes but it is better then doing function overloading based > on parameters passed. > I see. This part must be fixed in the next version. -- Thanks. HATAYAMA, Daisuke _______________________________________________ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx103.postini.com [74.125.245.103]) by kanga.kvack.org (Postfix) with SMTP id 8BD8A6B0033 for ; Thu, 16 May 2013 19:47:20 -0400 (EDT) Received: from m2.gw.fujitsu.co.jp (unknown [10.0.50.72]) by fgwmail5.fujitsu.co.jp (Postfix) with ESMTP id 32F873EE0C1 for ; Fri, 17 May 2013 08:47:19 +0900 (JST) Received: from smail (m2 [127.0.0.1]) by outgoing.m2.gw.fujitsu.co.jp (Postfix) with ESMTP id 056F845DE4E for ; Fri, 17 May 2013 08:47:19 +0900 (JST) Received: from s2.gw.fujitsu.co.jp (s2.gw.fujitsu.co.jp [10.0.50.92]) by m2.gw.fujitsu.co.jp (Postfix) with ESMTP id DA4E345DE4D for ; Fri, 17 May 2013 08:47:18 +0900 (JST) Received: from s2.gw.fujitsu.co.jp (localhost.localdomain [127.0.0.1]) by s2.gw.fujitsu.co.jp (Postfix) with ESMTP id C675E1DB8038 for ; Fri, 17 May 2013 08:47:18 +0900 (JST) Received: from m1001.s.css.fujitsu.com (m1001.s.css.fujitsu.com [10.240.81.139]) by s2.gw.fujitsu.co.jp (Postfix) with ESMTP id 77FCF1DB803A for ; Fri, 17 May 2013 08:47:18 +0900 (JST) Message-ID: <51956FF6.3070205@jp.fujitsu.com> Date: Fri, 17 May 2013 08:47:02 +0900 From: HATAYAMA Daisuke MIME-Version: 1.0 Subject: Re: [PATCH v6 6/8] vmcore: allocate ELF note segment in the 2nd kernel vmalloc memory References: <20130515090507.28109.28956.stgit@localhost6.localdomain6> <20130515090614.28109.26492.stgit@localhost6.localdomain6> <20130516203236.GG5904@redhat.com> In-Reply-To: <20130516203236.GG5904@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Vivek Goyal Cc: riel@redhat.com, hughd@google.com, kexec@lists.infradead.org, linux-kernel@vger.kernel.org, lisa.mitchell@hp.com, linux-mm@kvack.org, kumagai-atsushi@mxc.nes.nec.co.jp, ebiederm@xmission.com, kosaki.motohiro@jp.fujitsu.com, zhangyanfei@cn.fujitsu.com, akpm@linux-foundation.org, walken@google.com, cpw@sgi.com, jingbai.ma@hp.com (2013/05/17 5:32), Vivek Goyal wrote: > On Wed, May 15, 2013 at 06:06:14PM +0900, HATAYAMA Daisuke wrote: > > [..] > >> +static int __init get_note_number_and_size_elf32(const Elf32_Ehdr *ehdr_ptr, >> + int *nr_ptnote, u64 *phdr_sz) >> +{ >> + return process_note_headers_elf32(ehdr_ptr, nr_ptnote, phdr_sz, NULL); >> +} >> + >> +static int __init copy_notes_elf32(const Elf32_Ehdr *ehdr_ptr, char *notes_buf) >> +{ >> + return process_note_headers_elf32(ehdr_ptr, NULL, NULL, notes_buf); >> +} >> + > > Please don't do this. We need to create two separate functions doing > two different operations and not just create wrapper around a function > which does two things. > > I know both functions will have similar for loops for going through > the elf notes but it is better then doing function overloading based > on parameters passed. > I see. This part must be fixed in the next version. -- Thanks. HATAYAMA, Daisuke -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755136Ab3EPXrY (ORCPT ); Thu, 16 May 2013 19:47:24 -0400 Received: from fgwmail6.fujitsu.co.jp ([192.51.44.36]:48455 "EHLO fgwmail6.fujitsu.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753541Ab3EPXrW (ORCPT ); Thu, 16 May 2013 19:47:22 -0400 X-SecurityPolicyCheck: OK by SHieldMailChecker v1.8.9 X-SHieldMailCheckerPolicyVersion: FJ-ISEC-20120718-2 Message-ID: <51956FF6.3070205@jp.fujitsu.com> Date: Fri, 17 May 2013 08:47:02 +0900 From: HATAYAMA Daisuke User-Agent: Mozilla/5.0 (Windows NT 5.1; rv:17.0) Gecko/20130509 Thunderbird/17.0.6 MIME-Version: 1.0 To: Vivek Goyal CC: riel@redhat.com, hughd@google.com, kexec@lists.infradead.org, linux-kernel@vger.kernel.org, lisa.mitchell@hp.com, linux-mm@kvack.org, kumagai-atsushi@mxc.nes.nec.co.jp, ebiederm@xmission.com, kosaki.motohiro@jp.fujitsu.com, zhangyanfei@cn.fujitsu.com, akpm@linux-foundation.org, walken@google.com, cpw@sgi.com, jingbai.ma@hp.com Subject: Re: [PATCH v6 6/8] vmcore: allocate ELF note segment in the 2nd kernel vmalloc memory References: <20130515090507.28109.28956.stgit@localhost6.localdomain6> <20130515090614.28109.26492.stgit@localhost6.localdomain6> <20130516203236.GG5904@redhat.com> In-Reply-To: <20130516203236.GG5904@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org (2013/05/17 5:32), Vivek Goyal wrote: > On Wed, May 15, 2013 at 06:06:14PM +0900, HATAYAMA Daisuke wrote: > > [..] > >> +static int __init get_note_number_and_size_elf32(const Elf32_Ehdr *ehdr_ptr, >> + int *nr_ptnote, u64 *phdr_sz) >> +{ >> + return process_note_headers_elf32(ehdr_ptr, nr_ptnote, phdr_sz, NULL); >> +} >> + >> +static int __init copy_notes_elf32(const Elf32_Ehdr *ehdr_ptr, char *notes_buf) >> +{ >> + return process_note_headers_elf32(ehdr_ptr, NULL, NULL, notes_buf); >> +} >> + > > Please don't do this. We need to create two separate functions doing > two different operations and not just create wrapper around a function > which does two things. > > I know both functions will have similar for loops for going through > the elf notes but it is better then doing function overloading based > on parameters passed. > I see. This part must be fixed in the next version. -- Thanks. HATAYAMA, Daisuke