Re: [Qemu-devel] [PATCH for-1.5] vl: new runstate transition: RUN_STATE_GUEST_PANICKED -> RUN_STATE_FINISH_MIGRATE

[Paolo Bonzini <pbonzini@redhat.com>]

Il 17/05/2013 09:43, Hu Tao ha scritto:
> On Fri, May 17, 2013 at 08:59:15AM +0200, Christian Borntraeger wrote:
>> On 05/04/13 08:36, Hu Tao wrote:
>>> The guest will be in this state when it is panicked.
>>>
>>> Signed-off-by: Wen Congyang <wency@cn.fujitsu.com>
>>> Signed-off-by: Hu Tao <hutao@cn.fujitsu.com>
>>
>> This actually broken virsh dump without --memory-only:
>>
>> ERROR: invalid runstate transition: 'guest-panicked' -> 'finish-migrate'
>>
>>
>> (virsh dump without memory-only falls back to migrate "exec: cat > dumpfile")
>>
>> Christian
> 
> This patch should fix the problem:
> 
> From d470feefe3d320c43c1fb2eb43457a99b96cdc98 Mon Sep 17 00:00:00 2001
> From: Hu Tao <hutao@cn.fujitsu.com>
> Date: Fri, 17 May 2013 15:39:07 +0800
> Subject: [PATCH] vl: new runstate transition: RUN_STATE_GUEST_PANICKED ->
>  RUN_STATE_FINISH_MIGRATE
> 
> This fixes a problem that after guest panic happens, virsh dump without
> --memory-only fails:
> 
> ERROR: invalid runstate transition: 'guest-panicked' -> 'finish-migrate'
> 
> Reported-by: Christian Borntraeger <borntraeger@de.ibm.com>
> Signed-off-by: Hu Tao <hutao@cn.fujitsu.com>

Adding qemu-stable, but perhaps we can get this into 1.5 as well.

Paolo

> ---
>  vl.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/vl.c b/vl.c
> index be0a93c..59dc0b4 100644
> --- a/vl.c
> +++ b/vl.c
> @@ -609,6 +609,7 @@ static const RunStateTransition runstate_transitions_def[] = {
>      { RUN_STATE_WATCHDOG, RUN_STATE_FINISH_MIGRATE },
>  
>      { RUN_STATE_GUEST_PANICKED, RUN_STATE_PAUSED },
> +    { RUN_STATE_GUEST_PANICKED, RUN_STATE_FINISH_MIGRATE },
>  
>      { RUN_STATE_MAX, RUN_STATE_MAX },
>  };
>