From: Olivier MATZ <olivier.matz-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
To: dev-VfR2kkLFssw@public.gmane.org
Subject: Re: [PATCH] lib: set version 1.2.3r2 and more helper macros
Date: Fri, 17 May 2013 11:12:23 +0200 [thread overview]
Message-ID: <5195F477.1050501@6wind.com> (raw)
In-Reply-To: <1367940644-13357-1-git-send-email-thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
Hi Thomas,
> @@ -75,7 +87,8 @@ rte_version(void) {
> return RTE_VER_PREFIX" "
> RTE_STR(RTE_VER_MAJOR)"."
> RTE_STR(RTE_VER_MINOR)"."
> - RTE_STR(RTE_VER_PATCH_LEVEL);
> + RTE_STR(RTE_VER_PATCH_LEVEL)"r"
> + RTE_STR(RTE_VER_PATCH_RELEASE);
> }
>
> #ifdef __cplusplus
In this patch, do you think it could be useful to add
a #ifdef RTE_VER_PATCH_RELEASE ? The idea is to return
"1.2.3" if there is no patch release and "1.2.3r4" in
the dpdk.org case. As a result this patch would be integrable
in Intel DPDK mainline.
The other lines of the patch look good to me.
Olivier
next prev parent reply other threads:[~2013-05-17 9:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-07 15:30 [PATCH] lib: set version 1.2.3r2 and more helper macros Thomas Monjalon
[not found] ` <1367940644-13357-1-git-send-email-thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
2013-05-17 9:12 ` Olivier MATZ [this message]
[not found] ` <5195F477.1050501-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
2013-05-17 14:46 ` Thomas Monjalon
[not found] ` <201305171646.00572.thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
2013-05-17 15:02 ` Olivier MATZ
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5195F477.1050501@6wind.com \
--to=olivier.matz-pdr9zngts4eavxtiumwx3w@public.gmane.org \
--cc=dev-VfR2kkLFssw@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.