From: John Crispin <john@phrozen.org>
To: Libo Chen <clbchenlibo.chen@huawei.com>
Cc: ralf@linux-mips.org, grant.likely@linaro.org,
rob.herring@calxeda.com, linux-mips@linux-mips.org,
LKML <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Li Zefan <lizefan@huawei.com>
Subject: Re: [PATCH] MIPS: drivers: fix clk leak
Date: Fri, 17 May 2013 11:24:00 +0200 [thread overview]
Message-ID: <5195F730.6080103@phrozen.org> (raw)
In-Reply-To: <5195CC6B.1000607@huawei.com>
On 17/05/13 08:21, Libo Chen wrote:
>
> when gptu_r32 fail, we should put clk before return
>
> Signed-off-by: Libo Chen<libo.chen@huawei.com>
Acked-by: John Crispin <blogic@openwrt.org>
> ---
> arch/mips/lantiq/xway/gptu.c | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/arch/mips/lantiq/xway/gptu.c b/arch/mips/lantiq/xway/gptu.c
> index 9861c86..4fa577c 100644
> --- a/arch/mips/lantiq/xway/gptu.c
> +++ b/arch/mips/lantiq/xway/gptu.c
> @@ -169,6 +169,8 @@ static int gptu_probe(struct platform_device *pdev)
> if (((gptu_r32(GPTU_ID)>> 8)& 0xff) != GPTU_MAGIC) {
> dev_err(&pdev->dev, "Failed to find magic\n");
> gptu_hwexit();
> + clk_disable(clk);
> + clk_put(clk);
> return -ENAVAIL;
> }
>
prev parent reply other threads:[~2013-05-17 9:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-17 6:21 [PATCH] MIPS: drivers: fix clk leak Libo Chen
2013-05-17 6:21 ` Libo Chen
2013-05-17 9:24 ` John Crispin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5195F730.6080103@phrozen.org \
--to=john@phrozen.org \
--cc=akpm@linux-foundation.org \
--cc=clbchenlibo.chen@huawei.com \
--cc=grant.likely@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=lizefan@huawei.com \
--cc=ralf@linux-mips.org \
--cc=rob.herring@calxeda.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.