From: Rich Johnston <rjohnston@sgi.com>
To: Zheng Liu <gnehzuil.liu@gmail.com>
Cc: Zheng Liu <wenqing.lz@taobao.com>, xfs@oss.sgi.com
Subject: Re: [PATCH v2] xfstests: check falloc in 285
Date: Fri, 17 May 2013 07:18:03 -0500 [thread overview]
Message-ID: <51961FFB.5040605@sgi.com> (raw)
In-Reply-To: <1368351729-17778-1-git-send-email-wenqing.lz@taobao.com>
On 05/12/2013 04:42 AM, Zheng Liu wrote:
> From: Zheng Liu <wenqing.lz@taobao.com>
>
> As linux 3.8, ext4 has supported the seek data/hole operation for
> extent-based file and indirect-based file. But for indirect-based file
> it can not support the fallocate(2). This causes test 285 to fail since
> it assumes that all file systems which supports seek data/hole also
> support fallocate. So here we need to check it.
>
> Signed-off-by: Zheng Liu <wenqing.lz@taobao.com>
> Cc: Rich Johnston <rjohnston@sgi.com>
> ---
> tests/generic/285 | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/tests/generic/285 b/tests/generic/285
> index 22b4a08..d1a1baa 100644
> --- a/tests/generic/285
> +++ b/tests/generic/285
> @@ -40,6 +40,8 @@ trap "_cleanup; exit \$status" 0 1 2 3 15
> _supported_fs generic
> _supported_os Linux
>
> +_require_xfs_io_falloc
> +
> BASE_TEST_FILE=$TEST_DIR/seek_sanity_testfile
>
> [ -x $here/src/seek_sanity_test ] || _notrun "seek_sanitfy_tester not built"
>
Looks good.
Reviewed-by: Rich Johnston <rjohnston@sgi.com>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2013-05-17 12:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-12 9:42 [PATCH v2] xfstests: check falloc in 285 Zheng Liu
2013-05-17 12:18 ` Rich Johnston [this message]
2013-05-17 12:20 ` Rich Johnston
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51961FFB.5040605@sgi.com \
--to=rjohnston@sgi.com \
--cc=gnehzuil.liu@gmail.com \
--cc=wenqing.lz@taobao.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.